Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication is being handled by Env Vars and triggered through the configure function. #123

Closed
jawache opened this issue Sep 4, 2023 · 2 comments

Comments

@jawache
Copy link
Contributor

jawache commented Sep 4, 2023

In the spec for a model plugin we added a function called authenticate but so far in the only plugin that's implementing authentication it's

  • Happening through the use of env vars for security reasons (you would never provide user/pass in a yaml file)
  • Any setup/authentication is happening through the configure function.

So the proposal here is to remove the authenticate function from the spec for the Model Plugins.

@gnanakeethan
Copy link
Contributor

@jawache I am reviewing this on the potential usage with the Watt-Time API and it seems pretty essential. The ideal scenario of having credentials via Environment variables is good though.

@jawache jawache moved this to Backlog in IF Sep 24, 2023
@jmcook1186 jmcook1186 removed the status in IF Nov 9, 2023
@jmcook1186
Copy link
Contributor

Closing as outdated

@github-project-automation github-project-automation bot moved this to Done in IF Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants