Check if the manifest is already grouped

[zanete]

Why:
To resolve errors in if-check script and prevent error in edge case where user regroups an already-grouped manifest.

What:

Add a check to see if the manifest is already grouped according to the config. If the manifest is already grouped according to the given config, we should simply skip the regroup step.

The current behaviour, that we want to fix, is that the manifest regroup feature executes even the manifest is already grouped, which leads to additional, unnecessary levels of nesting.

Scope of work:

• implement acceptance criteria
• test cases added

Acceptance criteria

Scenario 1:

The following manifest:

# start
name: regroup
description: successful path
initialize:
  plugins: {}
tree:
  children:
    my-app:
      pipeline:
        regroup:
          - cloud/region
          - cloud/instance-type
      children:
        uk-west:
          children:
            A1:
              inputs:
                - timestamp: 2023-07-06T00:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 99
                - timestamp: 2023-07-06T05:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 23
                - timestamp: 2023-07-06T10:00
                  duration: 300
                  cloud/instance-type: A1
                  cloud/region: uk-west
                  cpu/utilization: 12
            B1:
              inputs:
                - timestamp: 2023-07-06T00:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 11
                - timestamp: 2023-07-06T05:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 67
                - timestamp: 2023-07-06T10:00
                  duration: 300
                  cloud/instance-type: B1
                  cloud/region: uk-west
                  cpu/utilization: 1

Should return the same exact file when run using if-run --regroup -m <manifest> (except for adding an execution node to context)

[jmcook1186]

@narekhovhannisyan added some detail to the ticket

[zanete]

Expecting a PR today

[zanete]

This issue needs to be re-refined, especially after a possible resolution will be found in relation to time grid

[zanete]

@narekhovhannisyan please describe why this needed to be re-refined, where was the block why PR couldn't be created, if you can support by adding the slack conversation 🙏

[zanete]

@narekhovhannisyan please check this one today so you have stuff to do next week 🙏

[narekhovhannisyan]

@zanete @jmcook1186 Since regroup logic is in the compute phase, the plugin is executed on the leaf node, so we can't check if it has nested children (for skipping purposes).

[zanete]

assuming that the solution is

• 0. Check if regroup is enabled
• 1. check the regroup criteria
• 2. check if the subtree already is in the regrouped structure
• 3. if yes, then skip traversing the subtree
• 4. do this for all subtrees.

Estimate is about a couple of days

[zanete]

Status update: Expecting a PR today 💪