Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enhance HandlerGetPlayerTokenReq logic #2514

Closed
issueMel opened this issue May 27, 2024 · 2 comments
Closed

[Feature Request] Enhance HandlerGetPlayerTokenReq logic #2514

issueMel opened this issue May 27, 2024 · 2 comments
Labels
enhancement New feature or request suggestion A suggestion

Comments

@issueMel
Copy link

Is your feature request related to a problem? Please describe.

We can reduce the time of get player which account banned, if change the code position from HandlerGetPlayerTokenReq.java:97 to HandlerGetPlayerTokenReq.java:44.

if (session.getAccount().isBanned()) {
    ...
}

Describe the solution you'd like

Change the code from HandlerGetPlayerTokenReq.java:97 to HandlerGetPlayerTokenReq.java:44. Could I make a pull request for this?

Describe alternatives you've considered

Additional context

@issueMel issueMel added enhancement New feature or request suggestion A suggestion labels May 27, 2024
@KingRainbow44
Copy link
Member

yes you can absolutely PR this!

@issueMel
Copy link
Author

issueMel commented Jun 7, 2024

PacketGetPlayerTokenRsp.java:44 need player getAvatarCount() , so we still need setPlayer before check account state.
If I find a way to replace it, i will make a pr for this.

@issueMel issueMel closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request suggestion A suggestion
Projects
None yet
Development

No branches or pull requests

2 participants