Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to WCAG 2.2 #359

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Updating to WCAG 2.2 #359

merged 1 commit into from
Jun 14, 2024

Conversation

LRPerzus
Copy link
Contributor

@LRPerzus LRPerzus commented Jun 11, 2024 •
edited
Loading

Appending ejs files to fit them

This PR adds...

  • I've kept this PR as small as possible (~500 lines) by splitting it into PRs with manageable chunks of code
  • I've requested reviews from 1 reviewer
  • I've tested existing features (website scan, sitemap, custom flow) in both node index and cli
  • I've synced this fork with GovTechSG repo
  • I've added/updated unit tests
  • I've added/updated any necessary dependencies in package[-lock].json npm audit, portable installation on GitHub Actions

@LRPerzus
Updating to WCAG 2.2
0b383e9 
Appending ejs files to fit them
younglim
younglim approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@younglim younglim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younglim younglim merged commit b59f0ef into master Jun 14, 2024
1 check passed
@younglim younglim mentioned this pull request Jun 14, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younglim younglim younglim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LRPerzus @younglim