Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

concurrent map writes || concurrent map writes #176

Closed
MrGlp opened this issue Aug 7, 2023 · 3 comments
Closed

concurrent map writes || concurrent map writes #176

MrGlp opened this issue Aug 7, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@MrGlp
Copy link
Contributor

MrGlp commented Aug 7, 2023

调用 resolve 接口出错的,不能同时多个客户端调用这个么

info:fatal error: concurrent map writes
fatal error: concurrent map writes

goroutine 1357 [running]:
github.com/GopeedLab/gopeed/pkg/download.(*Downloader).Resolve(0xc000132720, 0xc0001401e0)
C:/Users/Thinkpad/go/pkg/mod/github.com/!gopeed!lab/[email protected]/pkg/download/downloader.go:204 +0xc5
offline-download/app/service.(*OfflineDownload).SubmitOfflineDownloadTask(0xc0000ee3c0?, {0xfd36a0?, 0xc000424008?}, 0x2?)


There is an error in calling the resolve interface, can’t multiple clients call this at the same time?

info: fatal error: concurrent map writes
fatal error: concurrent map writes

goroutine 1357 [running]:
github.com/GopeedLab/gopeed/pkg/download.(*Downloader).Resolve(0xc000132720, 0xc0001401e0)
C:/Users/Thinkpad/go/pkg/mod/github.com/!gopeed!lab/[email protected]/pkg/download/downloader.go:204 +0xc5
offline-download/app/service.(*OfflineDownload).SubmitOfflineDownloadTask(0xc0000ee3c0?, {0xfd36a0?, 0xc000424008?}, 0x2?)

@github-actions github-actions bot changed the title concurrent map writes concurrent map writes || concurrent map writes Aug 7, 2023
@monkeyWie
Copy link
Member

monkeyWie commented Aug 8, 2023

看样子得使用sync.map了,你有兴趣提供pr改一下吗


It seems that you have to use sync.map, are you interested in providing pr to change

@monkeyWie monkeyWie added the bug Something isn't working label Aug 8, 2023
@monkeyWie monkeyWie changed the title concurrent map writes || concurrent map writes concurrent map writes Aug 8, 2023
@github-actions github-actions bot changed the title concurrent map writes concurrent map writes || concurrent map writes Aug 8, 2023
@MrGlp
Copy link
Contributor Author

MrGlp commented Aug 8, 2023

好的,期待参与 gopeed 得建设,我这周抽时间改了提 mr 你来负责把关

Sure, looking forward to contributing to gopeed's development. I'll take some time this week to make the changes and submit the pull request. You can be in charge of reviewing it.

@MrGlp
Copy link
Contributor Author

MrGlp commented Aug 12, 2023

repired

@MrGlp MrGlp closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants