fix(ko): Do not add -trimpath when debugging
#6874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ko` adds the `-trimpath` flag to `go build` by default, as this aids in achieving reproducible builds. The `-trimpath` flag removes file system paths from the resulting binary, and this makes interactive debugging more difficult. This change instructs `ko` to _not_ add the `-trimpath` flag when users run `skaffold debug` with the `ko` builder. Bumps the `ko` version to pick up the `Trimpath` build option. Also, simplifies the `ko` example config since it's no longer necessary to add a non-empty `flags` field to `skaffold.yaml` to allow for interactive debugging. Fixes: GoogleContainerTools#6843 Tracking: GoogleContainerTools#6041
Codecov Report
@@ Coverage Diff @@
## main #6874 +/- ##
==========================================
- Coverage 70.48% 69.13% -1.35%
==========================================
Files 515 547 +32
Lines 23150 25081 +1931
==========================================
+ Hits 16317 17340 +1023
- Misses 5776 6576 +800
- Partials 1057 1165 +108
Continue to review full report at Codecov.
|
tejal29
approved these changes
Nov 18, 2021
tejal29
pushed a commit
that referenced
this pull request
Nov 18, 2021
`ko` adds the `-trimpath` flag to `go build` by default, as this aids in achieving reproducible builds. The `-trimpath` flag removes file system paths from the resulting binary, and this makes interactive debugging more difficult. This change instructs `ko` to _not_ add the `-trimpath` flag when users run `skaffold debug` with the `ko` builder. Bumps the `ko` version to pick up the `Trimpath` build option. Also, simplifies the `ko` example config since it's no longer necessary to add a non-empty `flags` field to `skaffold.yaml` to allow for interactive debugging. Fixes: #6843 Tracking: #6041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
koadds the-trimpathflag togo buildby default, as this aids in achieving reproducible builds.The
-trimpathflag removes file system paths from the resulting binary, and this makes interactive debugging more difficult.This change instructs
koto not add the-trimpathflag when users runskaffold debugwith thekobuilder.Bumps the
koversion to pick up theTrimpathbuild option.Also, simplifies the
koexample config since it's no longer necessary to add a non-emptyflagsfield toskaffold.yamlto allow for interactive debugging.Fixes: #6843
Tracking: #6041
Related: ko-build/ko#505