Detect ko images for debugging, by envvar #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All container images built by ko have the `KO_DATA_PATH` environment variable set: https://github.com/google/ko#static-assets This can be used for images built using Skaffold's ko builder (when ready), and for images build using ko via a custom build (usable now). Tracking: GoogleContainerTools#6041
Codecov Report
@@ Coverage Diff @@
## main #6563 +/- ##
==========================================
+ Coverage 70.48% 70.53% +0.04%
==========================================
Files 515 515
Lines 23150 23150
==========================================
+ Hits 16317 16328 +11
+ Misses 5776 5768 -8
+ Partials 1057 1054 -3
Continue to review full report at Codecov.
|
halvards
changed the title
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Sep 6, 2021
**Description** Container images built by ko have the [author](https://github.com/opencontainers/image-spec/blob/main/config.md#properties) property set to the value [`github.com/google/ko`](https://github.com/google/ko/blob/v0.8.3/pkg/build/gobuild.go#L610). Skaffold debug can use this property to detect a Go runtime artifact. This feature can be used for images built using Skaffold's ko builder (when ready), and for images build using ko via a custom build (usable now). **Tracking**: GoogleContainerTools#6041 **Related**: GoogleContainerTools#6563 **Context**: GoogleContainerTools#6496 (comment)
gsquared94
approved these changes
Sep 7, 2021
tejal29
pushed a commit
that referenced
this pull request
Sep 8, 2021
**Description** Container images built by ko have the [author](https://github.com/opencontainers/image-spec/blob/main/config.md#properties) property set to the value [`github.com/google/ko`](https://github.com/google/ko/blob/v0.8.3/pkg/build/gobuild.go#L610). Skaffold debug can use this property to detect a Go runtime artifact. This feature can be used for images built using Skaffold's ko builder (when ready), and for images build using ko via a custom build (usable now). **Tracking**: #6041 **Related**: #6563 **Context**: #6496 (comment)
halvards
added a commit
to halvards/skaffold
that referenced
this pull request
Sep 13, 2021
Disable Go compiler optimizations when building an artifact with the ko builder, and the Skaffold run mode is debug. **Tracking**: GoogleContainerTools#6041 **Related**: GoogleContainerTools#6563, GoogleContainerTools#6569
MarlonGamez
pushed a commit
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All container images built by ko have the
KO_DATA_PATHenvironment variable set: https://github.com/google/ko#static-assetsThis can be used for images built using Skaffold's ko builder (when ready), and for images built using ko via a custom build (usable now).
Tracking: #6041
Related: #6569
Context: #6496 (comment)