Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v2.14.0 #9668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

plumpy
Copy link
Collaborator

@plumpy plumpy commented Jan 15, 2025

Ran release/hack.sh and updated the CHANGELOG.md.

I chopped the CHANGELOG.md file to remove everything before 2.0.0. The file was so big that GitHub refused to display it.

The failing linter is expected because it checks the schema version against the latest release in GCS.

Ran release/hack.sh and updated the CHANGELOG.md.

I chopped the CHANGELOG.md file to remove everything before 2.0.0. The
file was so big that GitHub refused to display it.
@plumpy plumpy requested a review from alphanota January 15, 2025 22:50
@plumpy plumpy requested a review from a team as a code owner January 15, 2025 22:50
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, release: v2.14.0, is a release PR that updates Skaffold to version 2.14.0. The changes include:

  • Updating the version in docs-v2/content/en/schemas/version-mappings/v4beta12-version.json: The binVersion is updated to 2.14.0, and the releaseNoteLink points to the corresponding GitHub release.
  • Updating the API version in numerous example skaffold.yaml files: The apiVersion is updated from skaffold/v4beta11 to skaffold/v4beta12 across many example configurations. This is consistent across all examples, including examples/bazel, examples/buildpacks*, examples/cross-platform-builds, examples/custom*, examples/dev-journey-buildpacks, examples/docker-deploy, examples/gcb-kaniko, examples/generate-pipeline, examples/getting-started*, examples/go-integration-coverage, examples/google-cloud-build, examples/grpc-e2e-tests, examples/helm-deployment*, examples/hot-reload, examples/jib*, examples/kaniko, examples/ko*, examples/kustomize*, examples/lifecycle-hooks, examples/microservices, examples/multi-config-microservices*, examples/multiple-renderers, examples/nodejs, examples/profile-patches, examples/profiles, examples/react-reload*, examples/remote-multi-config-microservices, examples/ruby, examples/simple-artifact-dependency, examples/structure-tests, examples/tagging-with-environment-variables, examples/templated-fields, examples/typescript, and examples/using-env-file.
  • Updating examples/ruby/backend/Gemfile.lock: The nio4r gem version is updated from 2.7.4 to 2.7.3.
  • Updating pkg/skaffold/schema/latest/config.go: A warning was added to indicate that the v4beta12 config version is released and should not be modified.
  • Modifying examples/structure-tests/README.md: Minor formatting changes were made to improve readability.

The author also shortened the CHANGELOG.md file to improve GitHub's display capabilities.

I'll be looking at the impact of these changes on the overall system and will provide a more detailed review shortly.

And now, a little haiku to brighten your day:

Version bump complete,
New features shine so brightly,
Code review awaits.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the Skaffold examples and schema to v4beta12, updates the changelog, and downgrades the nio4r dependency in the Ruby example. The changes look good overall. Truncating the changelog is a reasonable approach to address the size issue. Updating the Skaffold version in the examples ensures compatibility with the latest features and fixes. However, it would be beneficial to understand the reason for the nio4r downgrade and ensure it doesn't introduce any regressions.

@idsulik
Copy link
Contributor

idsulik commented Jan 17, 2025

Oh, great news! can't wait for the release!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants