Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently skaffold as a helm post-renderer does not properly hand allow & deny list -> StatefulSet no longer handled properly #8084

Closed
aaron-prindle opened this issue Nov 13, 2022 · 0 comments · Fixed by #8085
Labels
deploy/helm priority/p1 High impact feature/bug. v2 regression Regressions from merging the v2 branch into main
Milestone

Comments

@aaron-prindle
Copy link
Contributor

aaron-prindle commented Nov 13, 2022

In v2.X.X skaffold is used as a helm post-renderer (via skaffold filter). There is an issue currently - root cause here:
https://github.com/GoogleContainerTools/skaffold/blob/main/cmd/skaffold/app/cmd/filter.go#L121
s/allow[groupkind]/deny[groupkind]

which does not properly configure the allow & deny list for the skaffold post-render usage. This leads to a regression where StatefulSets do not have their image fields updated properly when used with helm for Skaffold v2.0.1. See:
#8002 (comment)

for an repro example showing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy/helm priority/p1 High impact feature/bug. v2 regression Regressions from merging the v2 branch into main
Projects
None yet
1 participant