Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm [UPDATED] docs only partially? #8048

Closed
falcorocks opened this issue Nov 7, 2022 · 3 comments
Closed

Helm [UPDATED] docs only partially? #8048

falcorocks opened this issue Nov 7, 2022 · 3 comments

Comments

@falcorocks
Copy link

Hey all,

I'm trying to use v2 with helm, but I can't get the image tagging to override as intended. I may be missing something, but It looks like the docs were updated only partially:

section title at https://skaffold.dev/docs/pipeline-stages/deployers/helm/#configuring-your-helm-project-with-skaffold says

No more `artifactsOverride`
Skaffold no longer requires the intricate configuring of artifactsOverride and image naming strategies.

but then the immediately following subsection https://skaffold.dev/docs/pipeline-stages/deployers/helm/#image-configuration gives an example using artifactsOverride, which skaffold v2 is not happy with!

So without a working example in the docs, how do I configure helm and images overrides in v2?

@falcorocks falcorocks changed the title Helm [UPDATED] Helm [UPDATED] docs only partially? Nov 7, 2022
@johnnyhuy
Copy link

Used setValuesTemplates instead based on this document

---
apiVersion: skaffold/v3alpha1
kind: Config
metadata:
  name: example
build:
  artifacts:
    - image: examplecr
deploy:
  helm:
    releases:
      - name: example
        chartPath: charts/example

        # this
        setValueTemplates:
          image: '{{.IMAGE_REPO}}:{{.IMAGE_TAG}}'

Not sure if this is expected to be the official solution 🤔

@renzodavid9
Copy link
Contributor

Related with #8002

@aaron-prindle
Copy link
Contributor

Thanks for pointing this out, we are currently working on updating this. If you use skaffold fix this should update your skaffold.yaml value to have the appropriate setValues or setValueTemplates stanza (from the now removed artifactOverrides). Closing as dupe of #8002, follow along there for updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants