Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set lower "kubectl delete --grace-period" for dev cleanup #771

Closed
ahmetb opened this issue Jun 29, 2018 · 0 comments
Closed

set lower "kubectl delete --grace-period" for dev cleanup #771

ahmetb opened this issue Jun 29, 2018 · 0 comments
Assignees

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Jun 29, 2018

skaffold v0.8.0

This is semi-related to #770. I think when someone is doing dev, it's most likely OK to do a kubectl delete --grace-period=1 seconds (which I believe overrides pod's terminationGracePeriodSeconds and if that's unspecified, kubernetes default of 30 second for this value).

This would provide faster cleanups (and therefore exits) if/when cleanup stage properly waits for all resources to go away (as pointed out in #770).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants