Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold should provide more detail on parsing errors #5659

Closed
briandealwis opened this issue Apr 9, 2021 · 2 comments
Closed

Skaffold should provide more detail on parsing errors #5659

briandealwis opened this issue Apr 9, 2021 · 2 comments
Labels

Comments

@briandealwis
Copy link
Member

Invoking Skaffold with a skaffold.yaml produces a terse error message with no detail as the problem.

parsing skaffold config: error parsing skaffold configuration file

But skaffold fix will pinpoint the problematic line:

unable to parse config: yaml: unmarshal errors:
  line 4: field pimage not found in type latest.Artifact

We should report the problematic line.

@kschaab
Copy link

kschaab commented May 17, 2021

I think the priority is incorrect on this as this error is also returned from skaffold diagnose as well. Considering this:

  # Search for configuration issues and print the effective configuration
  skaffold diagnose

it seems like configuration issues like these should be more detailed than:

skaffold diagnose --yaml-only --filename skaffold.yaml
WARN[0000] Your Skaffold version might be too old. Download the latest version (1.24.0) from:
  https://github.com/GoogleContainerTools/skaffold/releases/tag/v1.24.0
parsing skaffold config: error parsing skaffold configuration file

@briandealwis
Copy link
Member Author

briandealwis commented May 17, 2021

Oops, This was fixed in #5722 for Skaffold 1.23.0:

$ skaffold diagnose --yaml-only
WARN[0000] Your Skaffold version might be too old. Download the latest version (1.24.0) from:
  https://github.com/GoogleContainerTools/skaffold/releases/tag/v1.24.0 
parsing skaffold config: error parsing skaffold configuration file: parsing api version: yaml: line 4: could not find expected ':'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants