helm: delete doesn't respect namespace

[no1melman]

Expected behavior

Run

skaffold delete -n mynamespace

Everything should be cleaned up

Actual behavior

When running with custom namespace parameter, the delete command ignores it.
This doesn't help if you used run -n to put into a different namespace

Output from trace logs show command being run:

DEBU[0000] Running command: [helm --kube-context docker-for-desktop delete myrelease --namespace othernamespace] 

Information

• Skaffold version: 1.5.0
• Operating system: MacOS Mojave
• Contents of skaffold.yaml:

deploy:
  helm:
    releases:
    - name: myrelease
      chartPath: k8s/client
      values:
        image.repository: myrelease
      namespace: othernamespace

Steps to reproduce the behavior

Run

skaffold run -n mynamespace
skaffold delete -n mynamespace

[dgageot]

@no1melman are you using helm3 or a previous version?

[no1melman]

Helm 3

[no1melman]

@balopat do you require any more evidence?

[erpel]

Can confirm:

skaffold -v debug delete --namespace amqtest
...
DEBU[0000] Running command: [helm --kube-context zephyr-infra delete activemq]

$ helm version version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"} $ skaffold version v1.6.0

[abh]

This might be fixed in #3929

[tejal29]

We are prioritizing reviewing the PR and verifying this is Fixed in #3929

[tstromberg]

I looked through #3929 and don't see how it would fix this issue?

[tstromberg]

I tested this at head, but and it seems to be fixed now:

cd examples/helm-deployment-dependencies
skaffold run -n triage-party
skaffold delete -n triage-party

Example log:

DEBU[0000] Running command: [helm --kube-context minikube delete skaffold-helm --namespace triage-party] 
release "skaffold-helm" uninstalled

Please add a comment with the output of skaffold delete -n X -v=debug if you are still seeing this with the most recent Skaffold release.