Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add tag to image on skaffold deploy #2872

Closed
Jonathan34 opened this issue Sep 12, 2019 · 1 comment
Closed

Enhancement: Add tag to image on skaffold deploy #2872

Jonathan34 opened this issue Sep 12, 2019 · 1 comment
Labels

Comments

@Jonathan34
Copy link

Hi,

Context: I have one GCR, three clusters for 3 different environments (dev, staging, prod).

In CI, I build the image using skaffold build -q > build.out
-> images are tagged with gitCommitSha.

In CD, I deploy the images using skaffold deploy -a build.out using kustomize deploy.
I have an environment variable that tells me what to deploy (DEV, STG, PROD)
-> once deployed to dev: add a tag dev to the images
-> once deployed to staging: add a tag staging to the images
-> once deployed to prod: add a tag prod to the images

I cannot seem to find a way to do that automatically.

The only workaround i can think of is to parse the build.out after skaffold deploy succeed, and go one by one set the tags.

Any better idea or native way of doing that with skaffold?

@nkubala
Copy link
Contributor

nkubala commented Apr 24, 2020

this could be accomplished in a few ways (neither of which are yet supported in skaffold):

the second option here wouldn't be identical to what you're describing, since the tag would happen before the deploy phase (instead of after). would this be sufficient?

it's worth noting that both of these features will likely be implemented at some point in skaffold. since they're both being tracked in separate issues, i'll close this one for now (though feel free to continue the discussion here).

@nkubala nkubala closed this as completed Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants