Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ko? #1958

Closed
evankanderson opened this issue Apr 14, 2019 · 5 comments
Closed

Support for ko? #1958

evankanderson opened this issue Apr 14, 2019 · 5 comments

Comments

@evankanderson
Copy link

I'd like to be able to use ko to build binaries with Skaffold

Expected behavior

There are some docs about how to use ko with skaffold.

Actual behavior

No docs.

Information

  • Skaffold version: head / current docs
  • Operating system: Windows

/kind feature-request

@balopat
Copy link
Contributor

balopat commented Apr 15, 2019

Thanks for opening this! Yes, this came up before, I'd love to see ko integrated. One tricky bit is that ko is a builder and a deployer at the same time, but probably we can work something out.

We are working on the extensibility model for skaffold builders currently, so things are a bit up in the air, as soon as that settled, we will be able to fit ko in theoretically.

@evankanderson
Copy link
Author

evankanderson commented Apr 16, 2019 via email

@tejal29
Copy link
Contributor

tejal29 commented Aug 22, 2019

We should try to add an example for ko custom builder. Maybe we could add this for github.com/tektoncd/pipelines

@tejal29 tejal29 added priority/p2 May take a couple of releases good first issue Good for newcomers labels Aug 22, 2019
@tejal29
Copy link
Contributor

tejal29 commented Aug 22, 2019

@evankanderson please feel free to take a stab as per the docs mentioned https://skaffold.dev/docs/how-tos/builders/#custom-build-script-run-locally

@tstromberg
Copy link
Contributor

I'm closing this as it's been a while, and there are still no plans to create a 'ko' builder.

That said, we now show how to use ko as a custom builder in examples/custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants