Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support optional dependencies #59

Merged
merged 4 commits into from
Nov 15, 2024
Merged

feat: support optional dependencies #59

merged 4 commits into from
Nov 15, 2024

Conversation

thesayyn
Copy link
Collaborator

WIP, fixes #27

@loosebazooka
Copy link
Member

How do optionals work?
If I see an optional dep -- but it's included by someone else as non-optional then I resolve it?

@thesayyn
Copy link
Collaborator Author

If I see an optional dep -- but it's included by someone else as non-optional then I resolve it

optional is misnomer by me, it basically means, either one of these packages are required.

@thesayyn thesayyn merged commit 45509b0 into main Nov 15, 2024
10 checks passed
@jjmaestro jjmaestro mentioned this pull request Nov 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Support optional dependencies
3 participants
@thesayyn @loosebazooka @alexeagle