[Feature Request] Add Support for Public ECR Gallery

[PatrickXYS]

Given we have launched Public ECR registry last week, we should expect feature-requests fron ECR users for using Kaniko with Public ECR Authentication.

So the whole story will be:

Add support in amazon-ecr-credential-helper -> amazon-ecr-credential-helper cut new release -> Send PR to kaniko and make sure we build latest image of amazon-ecr-credential-helper into our executor image.

Related issue: awslabs/amazon-ecr-credential-helper#248

/cc @tejal29 @priyawadhwa

Any insights will be appreciated!

[andreyvelich]

We would highly appreciate if we push this forward once amazon-ecr-credential-helper changes are done.
I assume that Dockerfile is using the latest package for the docker-credential-ecr-login, so we don't need to modify Kaniko codebase after new release for the amazon-ecr-credential-helper.

Just to be aware, do we have any approximate timelines when Kaniko folks are planning to make the new release ?

/cc @gaocegege @johnugeorge

[PatrickXYS]

We have PR for fixing awslabs/amazon-ecr-credential-helper#248

awslabs/amazon-ecr-credential-helper#253

So next step should be collaborating with Kaniko folks for embedding latest ECR Credential Helper and cut new release.

[andreyvelich]

Thank you @PatrickXYS!
Should we wait until this PR: awslabs/amazon-ecr-credential-helper#253 will be merged ?

[PatrickXYS]

Thank you @PatrickXYS!
Should we wait until this PR: awslabs/amazon-ecr-credential-helper#253 will be merged ?

Right, as long as the PR merged, we issue another PR in kaniko repo, and get it shipped.

[theofpa]

awslabs/amazon-ecr-credential-helper#253 has been merged and included in the latest 0.50 release. The next kaniko release will include it as it will be fetched during the docker build, I don't think we need a PR for that.

% go get -u github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/docker-credential-ecr-login
go: downloading github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20210211190242-b19192b6522b
go: downloading github.com/awslabs/amazon-ecr-credential-helper v0.5.0
...

[PatrickXYS]

@theofpa Thanks for confirmation! How is it going with Kaniko folk's release cadence?

[snooyen]

Has this been included in kaniko v1.5.0-debug or is this slated for the next release?

[theofpa]

Has this been included in kaniko v1.5.0-debug or is this slated for the next release?

yes!

% docker run -it --entrypoint=/kaniko/docker-credential-ecr-login gcr.io/kaniko-project/executor:debug version
0.6.3

@PatrickXYS this issue can be closed as @tejal29 silently pushed v1.5.0 last week!

[PatrickXYS]

Yeah very nice, we can close the issue as of now

/close