Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better logging format #1029

Closed
osela opened this issue Feb 5, 2020 · 1 comment · Fixed by #1031
Closed

better logging format #1029

osela opened this issue Feb 5, 2020 · 1 comment · Fixed by #1031
Labels
area/behavior all bugs related to kaniko behavior like running in as root good first issue Good for newcomers help wanted Looking for a volunteer! priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@osela
Copy link
Contributor

osela commented Feb 5, 2020

#327 forces logrus to output colored logs, which are very hard to parse using the built-in tools of log collectors like fluentd.

In case you want to keep the existing behaviour, will you be open to accept a PR to allow setting the log formatter using a flag?
@tejal29
Copy link
Contributor

tejal29 commented Feb 5, 2020

@osela we would not mind that at all. We could definitely add a flag like --color and set it true by default. You can set it to false to turn off color logging.

@tejal29 tejal29 added area/behavior all bugs related to kaniko behavior like running in as root good first issue Good for newcomers help wanted Looking for a volunteer! priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Feb 5, 2020
@osela osela mentioned this issue Feb 6, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/behavior all bugs related to kaniko behavior like running in as root good first issue Good for newcomers help wanted Looking for a volunteer! priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set log format using a flag osela/kaniko
2 participants
@tejal29 @osela