-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish static images as manifest lists. #591
Conversation
c11597e
to
cacc346
Compare
A sample run of this (on my project) produced: ``` crane manifest gcr.io/mattmoor-knative/static:nonroot { "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json", "manifests": [ { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 526, "digest": "sha256:2b4a48f7c192111b0ff59633f1ac68f0079b8e8306bf0c5cb55169241ba464c9", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 526, "digest": "sha256:9169d04187d456913f000daeddc3fa2c2ae2e27dca5297b697d5c1d6f5b132c7", "platform": { "architecture": "arm64", "os": "linux" } } ] } ```
cacc346
to
389a233
Compare
I see arm64 images under https://gcr.io/distroless/static 🤩 |
Ok, I redeployed https://pizzaplanetv1-test-image.default.mattmoor.io changing just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for dragging distroless kicking and screaming into its archful future
blocking by gcr.io/distroless/static-debian10 and gcr.io/distroless/cc 😭 |
@morlay those should be pretty easy to add next, I'm starting small 😉 |
@mattmoor Cool. i see the codebase is upgraded. Waiting those images to land on gcr.io |
A sample run of this (on my project) produced:
Based on: #586
Fixes: #583