Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish static images as manifest lists. #591

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

mattmoor
Copy link
Contributor

@mattmoor mattmoor commented Sep 28, 2020

A sample run of this (on my project) produced:

    crane manifest gcr.io/mattmoor-knative/static:nonroot
    {
       "schemaVersion": 2,
       "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
       "manifests": [
          {
             "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
             "size": 526,
             "digest": "sha256:2b4a48f7c192111b0ff59633f1ac68f0079b8e8306bf0c5cb55169241ba464c9",
             "platform": {
                "architecture": "amd64",
                "os": "linux"
             }
          },
          {
             "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
             "size": 526,
             "digest": "sha256:9169d04187d456913f000daeddc3fa2c2ae2e27dca5297b697d5c1d6f5b132c7",
             "platform": {
                "architecture": "arm64",
                "os": "linux"
             }
          }
       ]
    }

Based on: #586
Fixes: #583

@googlebot googlebot added the cla: yes CLAs look good label Sep 28, 2020
@mattmoor mattmoor force-pushed the publish-lists branch 2 times, most recently from c11597e to cacc346 Compare September 28, 2020 21:21
A sample run of this (on my project) produced:
```
crane manifest gcr.io/mattmoor-knative/static:nonroot
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 526,
         "digest": "sha256:2b4a48f7c192111b0ff59633f1ac68f0079b8e8306bf0c5cb55169241ba464c9",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 526,
         "digest": "sha256:9169d04187d456913f000daeddc3fa2c2ae2e27dca5297b697d5c1d6f5b132c7",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}
```
@mattmoor
Copy link
Contributor Author

I see arm64 images under https://gcr.io/distroless/static 🤩

@mattmoor
Copy link
Contributor Author

Ok, I redeployed https://pizzaplanetv1-test-image.default.mattmoor.io changing just .ko.yaml to include :nonroot-arm64 and it works 🤩

@mattmoor mattmoor mentioned this pull request Sep 28, 2020
Copy link
Contributor

@dekkagaijin dekkagaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dragging distroless kicking and screaming into its archful future

@morlay
Copy link
Contributor

morlay commented Sep 29, 2020

Can't wait to use this to add distroless arm64 build of istio https://github.com/querycap/istio

blocking by gcr.io/distroless/static-debian10 and gcr.io/distroless/cc 😭

@mattmoor
Copy link
Contributor Author

@morlay those should be pretty easy to add next, I'm starting small 😉

@morlay
Copy link
Contributor

morlay commented Sep 29, 2020

@mattmoor Cool. i see the codebase is upgraded. Waiting those images to land on gcr.io

@mattmoor mattmoor merged commit 82e0217 into GoogleContainerTools:master Sep 29, 2020
@mattmoor mattmoor deleted the publish-lists branch September 29, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLAs look good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distroless/static multi-arch
5 participants