Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): NodeJS images are not published with version name at all #558

Closed
davinkevin opened this issue Jul 29, 2020 · 2 comments · Fixed by #559
Closed

fix(): NodeJS images are not published with version name at all #558

davinkevin opened this issue Jul 29, 2020 · 2 comments · Fixed by #559

Comments

@davinkevin
Copy link

By reading the documentation, I see there are 3 versions of nodejs images:

  • Node.js v10 (gcr.io/distroless/nodejs:10) and its dependencies.
  • Node.js v12 (gcr.io/distroless/nodejs:12) and its dependencies.
  • Node.js v14 (gcr.io/distroless/nodejs:14) and its dependencies.

https://github.com/GoogleContainerTools/distroless/blob/master/experimental/nodejs/README.md

But, in the gcr, I see only two tags, one latest and another for debug.

image

https://console.cloud.google.com/gcr/images/distroless/GLOBAL/nodejs?gcrImageListsize=100

I think there is something strange about this

Thanks for your help/support, distroless images are really great 👍

@chanseokoh
Copy link
Member

We just added the images to the repo yesterday, but there seems a technical issue with auto-publishing them. From #556 (comment),

@chanseokoh I checked the node.js container registry and didn't see the images. I tried running the cloudbuild.yaml locally and ran into this error.

code/distroless > cloud-build-local --config=cloudbuild.yaml .
2020/07/28 15:23:56 RUNNER - [docker ps -a -q --filter name=step_[0-9]+|cloudbuild_|metadata]
2020/07/28 15:23:56 RUNNER - [docker network ls -q --filter name=cloudbuild]
2020/07/28 15:23:56 RUNNER - [docker volume ls -q --filter name=homevol|cloudbuild_]
2020/07/28 15:23:58 Error merging substitutions and validating build: Error validating build: invalid .artifacts field: cannot specify more than 100 images to build

It seems like there may be a hard limit of 100 images to be published by a single cloudbuild run. Before my commit there were 97 images being published and after there are 103. However I couldn't find anything in the cloudbuild docs about such a limit.

Not sure what your build pipeline looks like for this behind the scenes, but the easiest thing to do may be to have separate cloudbuild files for different directories java, cc, experimental etc

@chanseokoh
Copy link
Member

The images are now live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants