Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renames fleetscope and appfactory folders #218

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

amandakarina
Copy link
Collaborator

This PR renames 3-appfactory to 4-appfactory and 4-fleetscope to 3-fleetscope

@caetano-colin
Copy link
Collaborator

I don't know if that is intentional, but you will be losing the terraform.tfvars symlinks under fleetscope

maybe thats because tfvars is under .gitignore

you can force add the tfvars file by using git add -f filename

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amandakarina! LGTM

@@ -38,7 +38,7 @@ func TestSourceCymbalBank(t *testing.T) {
env_cluster_membership_ids := make(map[string]map[string][]string, 0)
for _, envName := range testutils.EnvNames {
env_cluster_membership_ids[envName] = make(map[string][]string, 0)
multitenant := tft.NewTFBlueprintTest(t, tft.WithTFDir(fmt.Sprintf("../../../2-multitenant/envs/%s", envName)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@apeabody apeabody merged commit 3f06411 into GoogleCloudPlatform:main Aug 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants