Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appinfra): configurable envs #154

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat(appinfra): configurable envs #154

merged 1 commit into from
Jul 18, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented May 28, 2024 •
edited
Loading

  • Replace appinfra's hard coded prod/non-prod/dev environments with a configurable list

@apeabody apeabody force-pushed the ap/multienv-appinfra branch 6 times, most recently from f464cd4 to 365c830 Compare May 29, 2024 03:37
@apeabody apeabody force-pushed the ap/multienv-appinfra branch 3 times, most recently from 23d2b1d to 4c4b9c4 Compare June 6, 2024 00:15
@apeabody apeabody mentioned this pull request Jun 6, 2024
Merged
@apeabody apeabody force-pushed the ap/multienv-appinfra branch 7 times, most recently from 33ae3b9 to 54a9e81 Compare June 12, 2024 22:06
@apeabody
Copy link
Collaborator Author 

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
        	            	
        	            	  with module.env.google_gke_hub_feature.mcs,
        	            	  on ../../modules/env_baseline/mcg.tf line 34, in resource "google_gke_hub_feature" "mcs":
        	            	  34: resource "google_gke_hub_feature" "mcs" {
        	            	}
        	Test:       	TestFleetscope/production

@apeabody
Copy link
Collaborator Author 

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
        	            	
        	            	  with module.env.google_gke_hub_feature.acm_feature,
        	            	  on ../../modules/env_baseline/acm.tf line 44, in resource "google_gke_hub_feature" "acm_feature":
        	            	  44: resource "google_gke_hub_feature" "acm_feature" {
        	            	}
        	Test:       	TestFleetscope/development

@apeabody apeabody force-pushed the ap/multienv-appinfra branch from 54a9e81 to eae0d78 Compare June 13, 2024 02:00
@apeabody
Copy link
Collaborator Author 

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
        	            	
        	            	  with module.env.google_gke_hub_feature.mcs,
        	            	  on ../../modules/env_baseline/mcg.tf line 34, in resource "google_gke_hub_feature" "mcs":
        	            	  34: resource "google_gke_hub_feature" "mcs" {
        	            	}
        	Test:       	TestFleetscope/non-production

@apeabody
Copy link
Collaborator Author 

        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
        	            	
        	            	  with module.env.google_gke_hub_feature.acm_feature,
        	            	  on ../../modules/env_baseline/acm.tf line 44, in resource "google_gke_hub_feature" "acm_feature":
        	            	  44: resource "google_gke_hub_feature" "acm_feature" {
        	            	}
        	Test:       	TestFleetscope/production

@apeabody
Copy link
Collaborator Author 

Step #8 - "fleetscope-apply":         	Error:      	Received unexpected error:
Step #8 - "fleetscope-apply":         	            	FatalError{Underlying: error while running command: exit status 1; 
Step #8 - "fleetscope-apply":         	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
Step #8 - "fleetscope-apply":         	            	
Step #8 - "fleetscope-apply":         	            	  with module.env.google_gke_hub_feature.mcs,
Step #8 - "fleetscope-apply":         	            	  on ../../modules/env_baseline/mcg.tf line 34, in resource "google_gke_hub_feature" "mcs":
Step #8 - "fleetscope-apply":         	            	  34: resource "google_gke_hub_feature" "mcs" {
Step #8 - "fleetscope-apply":         	            	}
Step #8 - "fleetscope-apply":         	Test:       	TestFleetscope/non-production

@apeabody
Copy link
Collaborator Author 

Step #8 - "fleetscope-apply":         	Error:      	Received unexpected error:
Step #8 - "fleetscope-apply":         	            	FatalError{Underlying: error while running command: exit status 1; 
Step #8 - "fleetscope-apply":         	            	Error: Error waiting to create Feature: Error waiting for Creating Feature: Error code 13, message: an internal error has occurred
Step #8 - "fleetscope-apply":         	            	
Step #8 - "fleetscope-apply":         	            	  with module.env.google_gke_hub_feature.acm_feature,
Step #8 - "fleetscope-apply":         	            	  on ../../modules/env_baseline/acm.tf line 44, in resource "google_gke_hub_feature" "acm_feature":
Step #8 - "fleetscope-apply":         	            	  44: resource "google_gke_hub_feature" "acm_feature" {
Step #8 - "fleetscope-apply":         	            	}
Step #8 - "fleetscope-apply":         	Test:       	TestFleetscope/non-production

@apeabody apeabody force-pushed the ap/multienv-appinfra branch 6 times, most recently from fc6d8a2 to 4da5a8d Compare June 14, 2024 16:26
@apeabody apeabody mentioned this pull request Jun 25, 2024
Closed
@apeabody apeabody force-pushed the ap/multienv-appinfra branch 5 times, most recently from 8225f5c to a4a3767 Compare July 1, 2024 22:20
@apeabody apeabody force-pushed the ap/multienv-appinfra branch 3 times, most recently from 3c34a86 to fb22a85 Compare July 10, 2024 23:19
@apeabody
Copy link
Collaborator Author

Seeing a lot similar to:

Step #11 - "appfactory-apply": TestAppfactory/cymbal-bank 2024-07-11T00:13:46Z retry.go:103: terraform [apply -input=false -auto-approve -var bucket_force_destroy=true -no-color -lock=false] returned an error: error while running command: exit status 1; 
Step #11 - "appfactory-apply": Error: Provider produced inconsistent result after apply
Step #11 - "appfactory-apply": 
Step #11 - "appfactory-apply": When applying changes to
Step #11 - "appfactory-apply": module.components["contacts"].google_sourcerepo_repository.app_infra_repo,
Step #11 - "appfactory-apply": provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
Step #11 - "appfactory-apply": unexpected new value: Root object was present, but now absent.
Step #11 - "appfactory-apply": 
Step #11 - "appfactory-apply": This is a bug in the provider, which should be reported in the provider's own
Step #11 - "appfactory-apply": issue tracker.
Step #11 - "appfactory-apply": 
Step #11 - "appfactory-apply": Error: Provider produced inconsistent result after apply
Step #11 - "appfactory-apply": 
Step #11 - "appfactory-apply": When applying changes to
Step #11 - "appfactory-apply": module.components["frontend"].google_sourcerepo_repository.app_infra_repo,
Step #11 - "appfactory-apply": provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
Step #11 - "appfactory-apply": unexpected new value: Root object was present, but now absent.
Step #11 - "appfactory-apply": 
Step #11 - "appfactory-apply": This is a bug in the provider, which should be reported in the provider's own
Step #11 - "appfactory-apply": issue tracker.. Sleeping for 2m0s and will try again.

@apeabody apeabody force-pushed the ap/multienv-appinfra branch 3 times, most recently from 50ce640 to 31ed932 Compare July 11, 2024 22:19
@apeabody
Copy link
Collaborator Author 

TestFleetscope/development 2024-07-12T15:40:12Z retry.go:144: 'terraform [apply -input=false -auto-approve -var cluster_project_id=eab-gke-development-69xp -var network_project_id=eab-vpc-development-lg6y -var fleet_project_id=eab-gke-development-69xp -var cluster_membership_ids=["//gkehub.googleapis.com/projects/eab-gke-development-69xp/locations/us-central1/memberships/cluster-us-central1-development"] -var namespace_ids={"transactions" = "[email protected]", "accounts" = "[email protected]", "frontend" = "[email protected]"} -no-color -lock=false --parallelism=1]' failed with the error 'error while running command: exit status 1; 
Error: Provider produced inconsistent result after apply

When applying changes to module.env.google_sourcerepo_repository.acm_repo,
provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
unexpected new value: Root object was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.' but this error was expected and warrants a retry. Further details: Provider eventual consistency error.

TestFleetscope/development 2024-07-12T15:40:12Z retry.go:103: terraform [apply -input=false -auto-approve -var cluster_project_id=eab-gke-development-69xp -var network_project_id=eab-vpc-development-lg6y -var fleet_project_id=eab-gke-development-69xp -var cluster_membership_ids=["//gkehub.googleapis.com/projects/eab-gke-development-69xp/locations/us-central1/memberships/cluster-us-central1-development"] -var namespace_ids={"transactions" = "[email protected]", "accounts" = "[email protected]", "frontend" = "[email protected]"} -no-color -lock=false --parallelism=1] returned an error: error while running command: exit status 1; 
Error: Provider produced inconsistent result after apply

When applying changes to module.env.google_sourcerepo_repository.acm_repo,
provider "provider[\"registry.terraform.io/hashicorp/google\"]" produced an
unexpected new value: Root object was present, but now absent.

This is a bug in the provider, which should be reported in the provider's own
issue tracker.. Sleeping for 2m0s and will try again.

@apeabody apeabody force-pushed the ap/multienv-appinfra branch 4 times, most recently from 0bfc89f to 8447f7e Compare July 15, 2024 23:29
@apeabody apeabody force-pushed the ap/multienv-appinfra branch from 8447f7e to f492332 Compare July 15, 2024 23:39
@apeabody apeabody marked this pull request as ready for review July 16, 2024 17:29
gtsorbo
gtsorbo approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@gtsorbo gtsorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

@gtsorbo gtsorbo merged commit 1e1fa2e into main Jul 18, 2024
6 checks passed
@gtsorbo gtsorbo deleted the ap/multienv-appinfra branch July 18, 2024 18:57
@release-please release-please bot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsorbo gtsorbo gtsorbo approved these changes

@erictune erictune Awaiting requested review from erictune

@yliaog yliaog Awaiting requested review from yliaog yliaog is a code owner

@sleighton2022 sleighton2022 Awaiting requested review from sleighton2022 sleighton2022 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeabody @gtsorbo