Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multitenant): refactor multitenant to be multi-app configurable #148

Merged
merged 1 commit into from
May 24, 2024

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented May 23, 2024

2-multitenant

  • remove all hard coding for bank of anthos
  • adds a new apps variable
variable "apps" {
  description = "Applications"
  type = map(object({
    ip_address_names = list(string)
  }))
}
  • external ip addresses are now created based on ip_address_names in the new apps variable
  • service accounts are now created for each app defined in the apps variable
  • dynamic ip address test based on new global AppNames = []string testutils variable
  • remove endpoints in favor of the updated dynamic ip address test
  • dynamic service account test based on new global AppNames = []string testutils variable

@apeabody apeabody changed the title fix: refactor multienant to be multi-app fix: refactor multitenant to be multi-app May 23, 2024
@apeabody apeabody changed the title fix: refactor multitenant to be multi-app fix: refactor multitenant to be multi-app configurable May 23, 2024
@apeabody apeabody force-pushed the ap/multi-app-multitenant branch 10 times, most recently from 2ecb5d0 to 1d15df5 Compare May 24, 2024 04:32
@apeabody apeabody marked this pull request as ready for review May 24, 2024 15:24
@apeabody apeabody changed the title fix: refactor multitenant to be multi-app configurable feat: refactor multitenant to be multi-app configurable May 24, 2024
@apeabody apeabody changed the title feat: refactor multitenant to be multi-app configurable feat(multitenant): refactor multitenant to be multi-app configurable May 24, 2024
@apeabody apeabody enabled auto-merge (squash) May 24, 2024 15:37
Copy link

@erictune erictune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request adding documentation of what an App is. Other comments are optional to address in this PR or later.

@apeabody apeabody force-pushed the ap/multi-app-multitenant branch from 1d15df5 to fafebec Compare May 24, 2024 18:26
@erictune
Copy link

LGTM based on #151

@apeabody apeabody force-pushed the ap/multi-app-multitenant branch from fafebec to 5f2f662 Compare May 24, 2024 18:32
@apeabody apeabody merged commit 64e8b40 into main May 24, 2024
5 checks passed
@apeabody apeabody deleted the ap/multi-app-multitenant branch May 24, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants