Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make lint, cft tests happy #31

Merged

Conversation

balajismaniam
Copy link
Contributor

No description provided.

@balajismaniam balajismaniam requested review from a team, asrivas, telpirion, yil532 and nicain as code owners July 5, 2023 19:55
@balajismaniam balajismaniam marked this pull request as draft July 5, 2023 19:59
@balajismaniam balajismaniam force-pushed the make-lint-cft-checks-work branch 12 times, most recently from d5b700f to 798d604 Compare July 6, 2023 19:27
@balajismaniam balajismaniam force-pushed the make-lint-cft-checks-work branch from 798d604 to f990ee1 Compare July 6, 2023 20:00
@balajismaniam balajismaniam marked this pull request as ready for review July 6, 2023 20:23
@balajismaniam balajismaniam reopened this Jul 6, 2023
@bharathkkb bharathkkb closed this Jul 6, 2023
@bharathkkb bharathkkb reopened this Jul 6, 2023
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments for TF

.github/workflows/lint.yaml Show resolved Hide resolved
test/setup/iam.tf Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
@telpirion telpirion merged commit fd85536 into GoogleCloudPlatform:main Jul 10, 2023
@balajismaniam balajismaniam deleted the make-lint-cft-checks-work branch July 10, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants