-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Memorystore documentation improvements #2737
docs: Memorystore documentation improvements #2737
Conversation
23b8d3e
to
f43c84d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to update our documentation!
And sorry for the delay in review process.
I've tested out and this looks great in general, only got a few comments below.
btw, I see the linked codelab also has outdated configurations, I will update those.
…store-documentation-improvements
Co-authored-by: Min Zhu <[email protected]>
@zhumin8 Thanks for your suggestions, I've applied them all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the fact that we use adoc instead of md formats, links in previous edits do not render correctly. Apologies for the extra work.
Otherwise this looks good to me. I will merge it in once these are updated.
Thanks again for contributing!
Co-authored-by: Min Zhu <[email protected]>
No problem, I've committed your suggested changes. |
Quality Gate passedIssues Measures |
This PR contains Memorystore documentation improvements as described in #2735.