Fix BigQuery setter bug and add tests #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
approved these changes
Feb 8, 2021
Lol. The sin of Copy/Paste |
elefeint
approved these changes
Feb 9, 2021
...a/com/google/cloud/spring/bigquery/integration/outbound/BigQueryFileMessageHandlerTests.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
prash-mi
pushed a commit
that referenced
this pull request
Jun 20, 2023
Remove TCK test overrides that were necessary due to DML syntax requiring column list in Spanner. R2DBC SPI 0.8.3 containing the TCK changes was released. I also upgraded Reactor to the same version that's in SPI. There are still two reasons for overrides: 1) Spanner returning `Long` even when `Integer` is requested -- work tracked in #276. 2) the driver breaking R2DBC spec by treating columns as case insensitive -- decision pending on #271.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
BigQueryFileMessageHandlerwhere it references the wrong variable in the setter.Add additional tests.