Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase CI check fails due to removed BUILD.bazel in sdk-platform-java #2214

Closed
diegomarquezp opened this issue Oct 2, 2023 · 1 comment · Fixed by #2895
Closed

Showcase CI check fails due to removed BUILD.bazel in sdk-platform-java #2214

diegomarquezp opened this issue Oct 2, 2023 · 1 comment · Fixed by #2895
Assignees
Labels

Comments

@diegomarquezp
Copy link
Contributor

googleapis/sdk-platform-java#1935 removed the showcase BUILD file, and now the script that manipulates such BUILD file is failing.

@diegomarquezp diegomarquezp self-assigned this Oct 2, 2023
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Oct 31, 2023

This section assumes the existence of BUILD.bazel in sdk-platform-java/showcase

# Modify sdk-platform-java/showcase/BUILD.bazel
buildozer 'new_load @spring_cloud_generator//:java_gapic_spring.bzl java_gapic_spring_library' BUILD.bazel:__pkg__
modify_build_file "BUILD.bazel"

It adds a java_gapic_spring_library rule

buildozer "new java_gapic_spring_library $SPRING_RULE_NAME" ${path_to_build_file}:__pkg__

The implementation of java_gapic_spring_library produces the following protoc command:

bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/protoc --experimental_allow_proto3_optional --plugin=protoc-gen-java_gapic_spring=bazel-out/k8-opt-exec-2B5CBBC6/bin/external/spring_cloud_generator/protoc-gen-java_gapic_spring --java_gapic_spring_out=metadata:bazel-out/k8-fastbuild/bin/showcase/showcase_java_gapic_spring_raw.srcjar.zip --java_gapic_spring_opt=transport=grpc+rest,grpc-service-config=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/showcase_grpc_service_config.json,api-service-config=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/showcase_v1beta1.yaml -Ischema/google/showcase/v1beta1/compliance.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/compliance.proto -Ischema/google/showcase/v1beta1/echo.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/echo.proto -Ischema/google/showcase/v1beta1/identity.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/identity.proto -Ischema/google/showcase/v1beta1/messaging.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/messaging.proto -Ischema/google/showcase/v1beta1/sequence.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/sequence.proto -Ischema/google/showcase/v1beta1/testing.proto=external/com_google_gapic_showcase/schema/google/showcase/v1beta1/testing.proto -Igoogle/api/annotations.proto=external/com_google_googleapis/google/api/annotations.proto -Igoogle/api/http.proto=external/com_google_googleapis/google/api/http.proto -Igoogle/protobuf/descriptor.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/descriptor_proto/google/protobuf/descriptor.proto -Igoogle/api/client.proto=external/com_google_googleapis/google/api/client.proto -Igoogle/api/launch_stage.proto=external/com_google_googleapis/google/api/launch_stage.proto -Igoogle/protobuf/duration.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/duration_proto/google/protobuf/duration.proto -Igoogle/api/field_behavior.proto=external/com_google_googleapis/google/api/field_behavior.proto -Igoogle/api/resource.proto=external/com_google_googleapis/google/api/resource.proto -Igoogle/api/routing.proto=external/com_google_googleapis/google/api/routing.proto -Igoogle/longrunning/operations.proto=external/com_google_googleapis/google/longrunning/operations.proto -Igoogle/rpc/status.proto=external/com_google_googleapis/google/rpc/status.proto -Igoogle/protobuf/any.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/any_proto/google/protobuf/any.proto -Igoogle/protobuf/empty.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/empty_proto/google/protobuf/empty.proto -Igoogle/rpc/error_details.proto=external/com_google_googleapis/google/rpc/error_details.proto -Igoogle/protobuf/field_mask.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/field_mask_proto/google/protobuf/field_mask.proto -Igoogle/protobuf/timestamp.proto=bazel-out/k8-fastbuild/bin/external/com_google_protobuf/src/google/protobuf/_virtual_imports/timestamp_proto/google/protobuf/timestamp.proto -Igoogle/cloud/common_resources.proto=external/com_google_googleapis/google/cloud/common_resources.proto -Igoogle/cloud/location/locations.proto=external/com_google_googleapis/google/cloud/location/locations.proto -Igoogle/iam/v1/iam_policy.proto=external/com_google_googleapis/google/iam/v1/iam_policy.proto -Igoogle/iam/v1/options.proto=external/com_google_googleapis/google/iam/v1/options.proto -Igoogle/iam/v1/policy.proto=external/com_google_googleapis/google/iam/v1/policy.proto -Igoogle/type/expr.proto=external/com_google_googleapis/google/type/expr.proto schema/google/showcase/v1beta1/compliance.proto schema/google/showcase/v1beta1/echo.proto schema/google/showcase/v1beta1/identity.proto schema/google/showcase/v1beta1/messaging.proto schema/google/showcase/v1beta1/sequence.proto schema/google/showcase/v1beta1/testing.proto google/cloud/common_resources.proto google/cloud/location/locations.proto google/iam/v1/iam_policy.proto

We need to replace the bazelisk call with something similar to the hermetic build script

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants