Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cherry-pick): Fix auditing when running through DatastoreTemplate.performTransaction #157

Merged
merged 1 commit into from
Dec 3, 2020
Merged

(cherry-pick): Fix auditing when running through DatastoreTemplate.performTransaction #157

merged 1 commit into from
Dec 3, 2020

Conversation

meltsufin
Copy link
Member

Port of spring-attic/spring-cloud-gcp#2604.

The new DatastoreTemplate instance should have the same
ApplicationEventPublisher as the original one, so that AuditingHandler
can be called.

@fpavageau @meltsufin
Fix auditing when running through DatastoreTemplate.performTransaction (
2149a02 
#2604)

The new `DatastoreTemplate` instance should have the same
`ApplicationEventPublisher` as the original one, so that `AuditingHandler`
can be called.

Fixes: #2603.
@google-cla
Copy link

google-cla bot commented Nov 30, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@meltsufin
Copy link
Member Author

@fpavageau would you mind signing the Google CLA to make it easier for us to merge this in?
Thanks!

dmitry-s
dmitry-s approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@dmitry-s dmitry-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpavageau
Copy link
Contributor

@googlebot I consent.

@fpavageau
Copy link
Contributor

Sorry, I'd missed the earlier notifications.

@meltsufin meltsufin merged commit 0b6558f into master Dec 3, 2020
@meltsufin meltsufin deleted the cherry-pick-2604 branch December 3, 2020 03:15
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
@kateryna216 @fpavageau
Fix auditing when running through DatastoreTemplate.performTransaction (
2281733 
GoogleCloudPlatform#2604) (GoogleCloudPlatform#157)

The new `DatastoreTemplate` instance should have the same
`ApplicationEventPublisher` as the original one, so that `AuditingHandler`
can be called.

Port of spring-attic/spring-cloud-gcp#2604.

Co-authored-by: Frank Pavageau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-s dmitry-s dmitry-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meltsufin @fpavageau @dmitry-s