Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords as top level attributes to base repeat experiments #484

Merged

Conversation

douglasjacobsen
Copy link
Collaborator

Previously, base experiments in a repeat set didn't have their top level attributes set correctly (i.e. application_name) which caused uploading to fail.

This merge adds the top level attributes to base experiments allowing them to be uploaded.

Previously, base experiments in a repeat set didn't have their top level
attributes set correctly (i.e. application_name) which caused uploading
to fail.

This commit adds the top level attributes to base experiments allowing
them to be uploaded.
@douglasjacobsen douglasjacobsen added the bug Something isn't working label May 10, 2024
Copy link
Collaborator

@dapomeroy dapomeroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dapomeroy dapomeroy merged commit 1e8f408 into GoogleCloudPlatform:develop May 10, 2024
5 checks passed
@douglasjacobsen douglasjacobsen deleted the fix_repeat_upload branch November 8, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants