Fix removal of scalars, and ignoring modifier variables #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes two issues with removal of unused variables, primarily related to removing variables that modifiers might use. The first fix updates the removal code to only remove list variables (as they are problematic for rendering experiments). The second fix propagates variables defined in a modifier (using the modifier_variable directive) as used variables even if they are not used in an expansion to ensure they are not removed accidentally.
douglasjacobsen
force-pushed
the
fix_variable_removal_modifiers
branch
from
7439dc3
to
43f4602
Compare
rfbgo
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge fixes two issues with removal of unused variables, primarily related to removing variables that modifiers might use.
The first fix updates the removal code to only remove list variables (as they are problematic for rendering experiments).
The second fix propagates variables defined in a modifier (using the modifier_variable directive) as used variables even if they are not used in an expansion to ensure they are not removed accidentally.