Fix object usage from modifier builtins #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, builtins defined within modifiers were called with an application instance in place of the `self` argument. This commit updates the executable graph to track the modifier object, and extract the builtin from the modifier when it will be used instead of at directive time.
douglasjacobsen
added
bug
rfbgo
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, modifier builtins that referenced self would cause an issue (because the application instance was passed as self instead of the modifier instance). This merge fixes this issue by forcing the object (application / modifier) extraction to happen later than it happened previously.
A test is also added to capture this in the future (and if tested before the last commit it fails).