-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video: fix flaky beta tests #3235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:'(
Different test is failing, which has been untouched so I need to go figure out why it now has an invalid argument. Possibly a change in the beta? Investigating. |
Well turns out we don't even have tests for local files across the board. :O |
I think the cat video is corrupted. As each time I use that video, it fails. But I tried another and it works... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One super small nit, otherwise LGTM.
Thanks @nnegrey for the fix. I'll merge once the tests pass |
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
* video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
* video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <[email protected]>
Fix: #3224
Fix: #3223
Fix: #3220