-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vision: delete obsolete beta snippets for logo detection #3114
vision: delete obsolete beta snippets for logo detection #3114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Confirmed that these samples are now irrelevant and the GA samples were merged: https://cloud.google.com/video-intelligence/docs/logo-recognition Moving this into ready-for-review. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly. In order to pass this check, please resolve this problem and then comment ℹ️ Googlers: Go here for more info. |
8c7d789
to
94e230c
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
hi @czahedi i'm fixing all fo the gross GH stuff now and then I'll review too |
94e230c
to
126ebf7
Compare
Thanks folks! |
…ogleCloudPlatform/python-docs-samples#3114) v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
…ogleCloudPlatform/python-docs-samples#3114) v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
) v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
) v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
…ogleCloudPlatform/python-docs-samples#3114) v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition So we're deleting the beta snippets which are now obsolete. [Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition
So we're deleting the beta snippets which are now obsolete.
[Set up pre-launch as draft, will push this change through once the above PR is complete and the docs are updated]