Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vision: delete obsolete beta snippets for logo detection #3114

Merged

Conversation

czahedi
Copy link
Contributor

@czahedi czahedi commented Mar 18, 2020

v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete.

[Set up pre-launch as draft, will push this change through once the above PR is complete and the docs are updated]

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2020
@czahedi czahedi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2020
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@czahedi
Copy link
Contributor Author

czahedi commented Apr 6, 2020

Confirmed that these samples are now irrelevant and the GA samples were merged: https://cloud.google.com/video-intelligence/docs/logo-recognition

Moving this into ready-for-review.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Apr 16, 2020
@leahecole leahecole force-pushed the vision-v1p3beta1-logo-delet-old-beta-snippets branch from 8c7d789 to 94e230c Compare April 16, 2020 21:46
@czahedi czahedi requested a review from nnegrey as a code owner April 16, 2020 21:46
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 16, 2020
@leahecole
Copy link
Collaborator

hi @czahedi i'm fixing all fo the gross GH stuff now and then I'll review too

@leahecole leahecole force-pushed the vision-v1p3beta1-logo-delet-old-beta-snippets branch from 94e230c to 126ebf7 Compare April 16, 2020 21:49
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Apr 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8f045c7 into master Apr 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the vision-v1p3beta1-logo-delet-old-beta-snippets branch April 16, 2020 22:08
@czahedi
Copy link
Contributor Author

czahedi commented Apr 16, 2020

Thanks folks!

busunkim96 pushed a commit to busunkim96/python-videointelligence that referenced this pull request May 20, 2020
…ogleCloudPlatform/python-docs-samples#3114)

v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete. 

[Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
danoscarmike pushed a commit to googleapis/python-videointelligence that referenced this pull request Sep 30, 2020
…ogleCloudPlatform/python-docs-samples#3114)

v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete. 

[Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
dizcology pushed a commit that referenced this pull request Sep 11, 2023
)

v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete. 

[Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
leahecole pushed a commit that referenced this pull request Sep 15, 2023
)

v1 snippets are published, via #3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete. 

[Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 22, 2023
…ogleCloudPlatform/python-docs-samples#3114)

v1 snippets are published, via GoogleCloudPlatform/python-docs-samples#3098 and shown on this docs page: https://cloud.google.com/video-intelligence/docs/logo-recognition

So we're deleting the beta snippets which are now obsolete. 

[Set up pre-launch as _draft_, will push this change through once the above PR is complete and the docs are updated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants