Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datalabeling tests are broken #2643

Closed
kurtisvg opened this issue Dec 21, 2019 · 11 comments
Closed

Datalabeling tests are broken #2643

kurtisvg opened this issue Dec 21, 2019 · 11 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@kurtisvg
Copy link
Contributor

Data labeling test are broken - likely a race condition when using a single project.

See #2642

@kurtisvg kurtisvg added the type: cleanup An internal cleanup or hygiene concern. label Dec 21, 2019
@gguuss
Copy link
Contributor

gguuss commented Dec 26, 2019

@kurtisvg Do you want to take this or should I? I'm happy to investigate but I saw that you'd done the change referenced in the commit and I was auto-assigned.

@kurtisvg
Copy link
Contributor Author

Happy to let you take over if you are willing - I was only attempting to update the snippets to use the test endpoint, which is how I discovered the tests were broken.

@gguuss
Copy link
Contributor

gguuss commented Dec 26, 2019

I'll take a look, currently waiting on a few other work items.

@gguuss
Copy link
Contributor

gguuss commented Dec 26, 2019

Anecdotally the tests are passing under nox in Python 2.7 and when directly invoked from Python 3.7 with pytest.

@gguuss
Copy link
Contributor

gguuss commented Dec 26, 2019

As mentioned in the bug this does seem to be specific to running the tests in parallel.

@gguuss
Copy link
Contributor

gguuss commented Dec 27, 2019

Repro in #2662

@gguuss
Copy link
Contributor

gguuss commented Dec 27, 2019

That branch got really messy, it appears to be a race condition in the teardown.

@gguuss
Copy link
Contributor

gguuss commented Dec 28, 2019

Progress in #2665 I have serialized the tests in that branch to try and determine the ordering of the build-up / tear down / timing that is causing the problem. Still failing though.

@gguuss
Copy link
Contributor

gguuss commented Feb 26, 2020

I was unable to resolve this, assigning to @kurtisvg

@gguuss gguuss assigned kurtisvg and unassigned gguuss Feb 26, 2020
@andrewferlitsch
Copy link
Contributor

@kurtisvg PTAL

@kurtisvg
Copy link
Contributor Author

kurtisvg commented Apr 1, 2020

Closing in favor of buildcop issues.

@kurtisvg kurtisvg closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants