Speech gapic client library #1012

dizcology · 2017-07-05T17:57:56Z

Updating python code samples to use the GAPIC python client library for Speech API.

Merge only after the client library is released.

jerjou · 2017-07-12T20:42:52Z

speech/cloud-client/requirements.txt

@@ -1 +1 @@
-google-cloud-speech==0.26.0
+google-cloud-speech>=0.27.0


Prefer all requirements be ==, for maximum reproducibility.

jerjou · 2017-07-12T20:47:42Z

speech/cloud-client/transcribe_streaming.py

+        language_code='en-US')
+
+    # In practice requests should be a generator yielding chunks of audio data.
+    requests = [request]


Might be clearer if you only construct the StreamingRecognizeRequest within a generator. ie:

requests = (types.StreamingRecognizeRequest(audio_content=c) for c in [content])

jerjou · 2017-07-12T20:49:49Z

speech/cloud-client/transcribe_streaming_mic.py

 # [END audio_stream]


-def listen_print_loop(results_gen):
+def listen_print_loop(responses):
    """Iterates through server responses and prints them.

    The results_gen passed is a generator that will block until a response


Should update the docstring as well

theacodes

Looks mostly good to me, with a few nits.

theacodes · 2017-07-13T16:01:46Z

speech/cloud-client/quickstart.py

+        audio = types.RecognitionAudio(content=content)
+
+    config = types.RecognitionConfig(
+        encoding='LINEAR16',


Is there an enum for this?

There is, but requires the additional import of from google.cloud.speech import enums. I was keeping it consistent with the existing samples.

theacodes · 2017-07-13T16:03:00Z

speech/cloud-client/transcribe_streaming.py

+        language_code='en-US')
+
+    # In practice requests should be a generator yielding chunks of audio data.
+    requests = (types.StreamingRecognizeRequest(audio_content=c)


please use a more descriptive variable name rather than c.

theacodes · 2017-07-13T16:04:18Z

speech/cloud-client/transcribe_streaming_mic.py

+        encoding='LINEAR16',
+        sample_rate_hertz=RATE,
+        language_code=language_code)
+    streaming_config = types.StreamingRecognitionConfig(config=config,


nit: start a newline at the opening ( to avoid hanging indents like this.

theacodes · 2017-07-13T21:28:40Z

Is it not in types?

…

On Thu, Jul 13, 2017, 2:25 PM Yu-Han Liu ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In speech/cloud-client/quickstart.py <#1012 (comment)> : > @@ -35,14 +36,16 @@ def run_quickstart(): # Loads the audio into memory with io.open(file_name, 'rb') as audio_file: content = audio_file.read() - sample = speech_client.sample( - content, - source_uri=None, - encoding='LINEAR16', - sample_rate_hertz=16000) + audio = types.RecognitionAudio(content=content) + + config = types.RecognitionConfig( + encoding='LINEAR16', There is, but requires the additional import of from google.cloud.speech import enums. I was keeping it consistent with the existing samples. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1012 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc62HIj0vuRiwZogfRuWk-1p2ZF2_ks5sNotegaJpZM4OOqyr> .

dizcology · 2017-07-13T21:31:53Z

in the current form of the GAPIC client library enums is its own module.

theacodes · 2017-07-13T21:37:32Z

I would still strongly prefer using an enum over magic values.

…

On Thu, Jul 13, 2017, 2:31 PM Yu-Han Liu ***@***.***> wrote: in the current form of the GAPIC client library enums is its own module. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1012 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPUc1vVDFylMQa2fm3ttba38Orwzup5ks5sNozKgaJpZM4OOqyr> .

theacodes

This LGTM, but I can't merge it until the 0.27.0 version of the library is published. Have you run these tests locally?

dizcology · 2017-07-14T18:42:50Z

I have tested with a client library provided to me to migrate these samples, but yes, let's wait after the package has been published and I have the chance to run the test against the published client.

dizcology · 2017-07-14T22:00:35Z

package published: https://pypi.python.org/pypi/google-cloud-speech/0.27.0

…-samples#1012) * Migrate quickstart to GAPIC client library * Migrate transcribe to GAPIC client library * Migrate transcribe_async to GAPIC client library * Migrate transcribe_streaming to GAPIC client library * clean up * clean up * Import from google.cloud.speech * update transcribe samples * import in alphabetic order * remove unused variable * use strings instead of enums * restructure code * comment on sreaming requests * import style * flake * correct indent * migrate transcribe_streaming_mic to gapic * update google-cloud-speech version requirement * addressing review comments * at the end of the audio stream, put None to signal to the generator * flake * addressing github review comments * add region tags for migration guide * update README * rst format * bullet * addressing PR review comments * use enums * remove a word

* Migrate quickstart to GAPIC client library * Migrate transcribe to GAPIC client library * Migrate transcribe_async to GAPIC client library * Migrate transcribe_streaming to GAPIC client library * clean up * clean up * Import from google.cloud.speech * update transcribe samples * import in alphabetic order * remove unused variable * use strings instead of enums * restructure code * comment on sreaming requests * import style * flake * correct indent * migrate transcribe_streaming_mic to gapic * update google-cloud-speech version requirement * addressing review comments * at the end of the audio stream, put None to signal to the generator * flake * addressing github review comments * add region tags for migration guide * update README * rst format * bullet * addressing PR review comments * use enums * remove a word

…-samples#1012) * Migrate quickstart to GAPIC client library * Migrate transcribe to GAPIC client library * Migrate transcribe_async to GAPIC client library * Migrate transcribe_streaming to GAPIC client library * clean up * clean up * Import from google.cloud.speech * update transcribe samples * import in alphabetic order * remove unused variable * use strings instead of enums * restructure code * comment on sreaming requests * import style * flake * correct indent * migrate transcribe_streaming_mic to gapic * update google-cloud-speech version requirement * addressing review comments * at the end of the audio stream, put None to signal to the generator * flake * addressing github review comments * add region tags for migration guide * update README * rst format * bullet * addressing PR review comments * use enums * remove a word

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 5, 2017

dizcology added 15 commits July 10, 2017 20:41

Migrate quickstart to GAPIC client library

aa0de94

Migrate transcribe to GAPIC client library

c695c82

Migrate transcribe_async to GAPIC client library

4777dc6

Migrate transcribe_streaming to GAPIC client library

e77f5f8

clean up

199a748

clean up

51c4d01

Import from google.cloud.speech

0de6c7c

update transcribe samples

a594c70

import in alphabetic order

9129caf

remove unused variable

4db0f45

use strings instead of enums

f09dfec

restructure code

66d53aa

comment on sreaming requests

99b2e79

import style

c7d1ad7

flake

ce0d25d

dizcology force-pushed the speech_gapic branch from d662f62 to ce0d25d Compare July 11, 2017 03:42

dizcology added 6 commits July 11, 2017 10:14

correct indent

3196c73

migrate transcribe_streaming_mic to gapic

d5acd7c

update google-cloud-speech version requirement

cb40b7f

addressing review comments

34ce758

at the end of the audio stream, put None to signal to the generator

0955793

flake

e355325

jerjou reviewed Jul 12, 2017

View reviewed changes

jerjou self-assigned this Jul 12, 2017

addressing github review comments

a5f4c35

jerjou approved these changes Jul 12, 2017

View reviewed changes

theacodes approved these changes Jul 13, 2017

View reviewed changes

dizcology added 2 commits July 13, 2017 14:00

add region tags for migration guide

73d2b79

update README

39f9b6b

dizcology added 2 commits July 13, 2017 14:11

rst format

efe110c

bullet

1f4cda6

addressing PR review comments

bd32ab4

dizcology added 2 commits July 13, 2017 16:05

use enums

1f861ee

remove a word

8fa2982

theacodes approved these changes Jul 14, 2017

View reviewed changes

theacodes merged commit 218bc59 into GoogleCloudPlatform:master Jul 14, 2017

telpirion mentioned this pull request Jan 13, 2023

chore(speech): migrate code from googleapis/python-speech #8982

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Speech gapic client library #1012

Speech gapic client library #1012

dizcology commented Jul 5, 2017

jerjou Jul 12, 2017

dizcology Jul 12, 2017

jerjou Jul 12, 2017

dizcology Jul 12, 2017

jerjou Jul 12, 2017

dizcology Jul 12, 2017

theacodes left a comment

theacodes Jul 13, 2017

dizcology Jul 13, 2017

theacodes Jul 13, 2017

dizcology Jul 13, 2017

theacodes Jul 13, 2017

dizcology Jul 13, 2017

theacodes commented Jul 13, 2017 via email

dizcology commented Jul 13, 2017

theacodes commented Jul 13, 2017 via email

theacodes left a comment

dizcology commented Jul 14, 2017

dizcology commented Jul 14, 2017

		@@ -1 +1 @@
		google-cloud-speech==0.26.0
		google-cloud-speech>=0.27.0

Speech gapic client library #1012

Speech gapic client library #1012

Conversation

dizcology commented Jul 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theacodes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theacodes commented Jul 13, 2017 via email

dizcology commented Jul 13, 2017

theacodes commented Jul 13, 2017 via email

theacodes left a comment

Choose a reason for hiding this comment

dizcology commented Jul 14, 2017

dizcology commented Jul 14, 2017