Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaulting logic for OperatorConfig's external labels during collection reconcile #1160

Open
pintohutch opened this issue Sep 30, 2024 · 0 comments

Comments

@pintohutch
Copy link
Collaborator

Currently, the collectionReconciler uses either:

  1. The operator's --project-id, --location, and --cluster labels, or
  2. The OperatorConfig.collection.externalLabels argument for project_id, location, and cluster

to enforce the corresponding metric labels on exported time series to Cloud Monitoring, with a preference for (2), given they are not necessarily needed for the operator to function and are more directly exposed to end users.

However, we neither intercept CREATE calls to the OperatorConfig with our defaulting webhooks, nor do we in-memory default the OperatorConfig during the collection reconcile loop (e.g. when a new PodMonitoring is created).

Thus, we should add both webhook-based and reconcile-based defaulting to ensure a more consistent UX when understanding our relabeling.

@pintohutch pintohutch removed their assignment Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant