Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf objects instead of dicts where possible #56

Closed
aabmass opened this issue Aug 7, 2020 · 3 comments · Fixed by #211
Closed

Use protobuf objects instead of dicts where possible #56

aabmass opened this issue Aug 7, 2020 · 3 comments · Fixed by #211

Comments

@aabmass
Copy link
Collaborator

aabmass commented Aug 7, 2020

Several places we are using dictionaries and then either letting the library convert or doing SomeProto(**d). It would be better to use protos directly

Waiting for #64

@tonyshi1998
Copy link

Hey! Is this still needed? I'd love to work on it if it is.

Also, is there a way I can message you @aabmass for a few quick questions? Thanks!

@aabmass
Copy link
Collaborator Author

aabmass commented Feb 1, 2022

@aabmass
Copy link
Collaborator Author

aabmass commented Feb 1, 2022

You can DM me on CNCF Slack https://slack.cncf.io/ 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants