fix(monitoring-exporter)!: use workload.googleapis.com as default metric prefix #455
+50
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
workload-domain
branch
from
8d3ef34 to
21b4416
Compare
…ric prefix Also removed the display name prefix. The OTel metric name without the GCM metric prefix is now used for display name.
aabmass
force-pushed
the
workload-domain
branch
from
21b4416 to
5bcb077
Compare
Codecov Report
@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 92.85% 92.74% -0.12%
==========================================
Files 13 13
Lines 448 441 -7
Branches 86 85 -1
==========================================
- Hits 416 409 -7
Misses 32 32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dashpole
approved these changes
Nov 30, 2022
|
Merging as is bc codecov isn't highlighting any code that is untested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed the display name prefix. The OTel metric name without the
GCM metric prefix is now used for display name.
Fixes #386