Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Run Jobs are detected as gcp_compute_engine #369

Closed
psx95 opened this issue Sep 12, 2024 · 2 comments
Closed

Cloud Run Jobs are detected as gcp_compute_engine #369

psx95 opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working priority: p2

Comments

@psx95
Copy link
Contributor

psx95 commented Sep 12, 2024

Currently, workloads running as Cloud Run Jobs are being detected as GCP compute engine - this is because the resource detection does not support Cloud Run Jobs yet which leads to resource detection logic fall back to gcp_compute_engine.

Environment variables in a Cloud Run Job container differ from the environment variables set when the container is run as a Cloud Run Service.

Details around the differences between environment variables are documented here.

Update resource detection logic to support Cloud Run Job detection.

@psx95 psx95 added the bug Something isn't working label Sep 12, 2024
@psx95 psx95 self-assigned this Sep 12, 2024
@dashpole
Copy link
Contributor

I think we implemented something in Go. We might want to duplicate that in java as well

@psx95
Copy link
Contributor Author

psx95 commented Sep 23, 2024

Both PRs have been merged, the next release of the contrib repository should have the updated resource detector. Closing this issue.

@psx95 psx95 closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: p2
Projects
None yet
Development

No branches or pull requests

2 participants