Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

instrumentation-quickstart example log4j2 config always sends logging.googleapis.com/trace_sampled: true #331

Open
aabmass opened this issue Apr 18, 2024 · 0 comments
Open

instrumentation-quickstart example log4j2 config always sends logging.googleapis.com/trace_sampled: true #331

aabmass opened this issue Apr 18, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation priority: p3

Comments

@aabmass
Copy link
Contributor

aabmass commented Apr 18, 2024 •
edited
Loading

We send true even if trace was not sampled. See apache/logging-log4j2#2482 for context. In the meantime, sending true keeps the "View trace details" button working. Added in #330
@aabmass aabmass added documentation Improvements or additions to documentation priority: p3 labels Apr 18, 2024
@aabmass aabmass mentioned this issue Apr 19, 2024
Merged
@aabmass aabmass changed the title instrumentation-quickstart example log4j2 config doesn't output logging.googleapis.com/trace_sampled instrumentation-quickstart example log4j2 config always sends logging.googleapis.com/trace_sampled: true Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation priority: p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aabmass