Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tracking metrics with Cloud Run resource type #946

Open
hrvadl opened this issue Nov 29, 2024 · 1 comment
Open

Add support for tracking metrics with Cloud Run resource type #946

hrvadl opened this issue Nov 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@hrvadl
Copy link

hrvadl commented Nov 29, 2024

Hi!

Here we fallback to the generic task resource type:

It would be nice to somehow map resource attributes to the Cloud Run resource type. From what I know we need to have these labels to track it correctly:

  • project_id
  • revision_name
  • service_name
  • location
  • configuration_name

OpenTelemetry collector with GCP resource detector collects the following attributes:

  • cloud.platform (with the value of gcp_cloud_run) by which we can determine that this is the Cloud Run resource type
  • faas.version -> revision_name?
  • cloud.account.id -> project_id?
  • cloud.region -> location?
  • faas.name -> service_name?
@dashpole
Copy link
Contributor

dashpole commented Dec 2, 2024

The main issue here is that we need the cloud run instance ID (faas.id) in order to differentiate between metrics from two different instances. Otherwise, you will get a variety of errors from the conflicting metrics.

@dashpole dashpole added the enhancement New feature or request label Dec 2, 2024
@dashpole dashpole self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants