Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated flags warning #37

Closed
damemi opened this issue Jan 27, 2023 · 1 comment · Fixed by #41
Closed

Fix deprecated flags warning #37

damemi opened this issue Jan 27, 2023 · 1 comment · Fixed by #41
Assignees
Labels
bug Something isn't working p2

Comments

@damemi
Copy link
Contributor

damemi commented Jan 27, 2023

I double checked on my side and it does work now.
However there is now a warning issued by the builder about deprecated arguments

$ make build
go install go.opentelemetry.io/collector/cmd/[email protected]
mkdir -p bin
builder --config=builder-config-izbk.yaml --name=otelcol-custom --output-path=bin/.
Flag --name has been deprecated, use config distribution::name
Flag --output-path has been deprecated, use config distribution::output_path

It can be fixed by removing the command line arguments in the Makefile and adding the following section in the builder-config.yaml

dist:
  name: otelcol-custom
  output_path: ./bin

Originally posted by @ljulliar in open-telemetry/opentelemetry-collector-contrib#17899 (comment)

@damemi damemi self-assigned this Jan 27, 2023
@damemi
Copy link
Contributor Author

damemi commented Jan 30, 2023

Triaged to me

@damemi damemi added bug Something isn't working p2 labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant