Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go client: NetworkIpRef requires Kind property which doesn't exist in v1alpha.ResourceRef type #675

Closed
3 tasks done
averzicco opened this issue Jun 29, 2022 · 2 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@averzicco
Copy link

Checklist

Bug Description

NetworkIpRef is v1alpha.ResourceRef type but the CRD for ComputeInstance requires also the Kind property, which is not part of v1alpha1.ResourceRef, this makes impossible to create ComputeInstance resource when it needs a ComputeAddress reference.

Validation fails with:
Invalid value: "":"spec.networkInterface.networkIpRef" must validate one and only one schema (oneOf). Found none valid, spec.networkInterface.networkIpRef.kind: Required value

Tested on v1.89.0 of the go client release

Additional Diagnostic Information

NetworkIpRef: &v1alpha1.ResourceRef{
	Name:      "compute-address",
	Namespace: "namespace",
},

Kubernetes Cluster Version

Client Version: v1.20.1 Server Version: v1.23.5-gke.2400

Config Connector Version

v1.89.0

Config Connector Mode

namespaced mode (default)

Log Output

Invalid value: "":"spec.networkInterface.networkIpRef" must validate one and only one schema (oneOf). Found none valid, spec.networkInterface.networkIpRef.kind: Required value

Steps to reproduce the issue

create a ComputeInstance object which refers a ComputeAddress in the networkInterface with go-client release v1.89.0 (latest available)

YAML snippets

No response

@averzicco averzicco added the bug Something isn't working label Jun 29, 2022
@caieo
Copy link
Contributor

caieo commented Jul 11, 2022

@averzicco, we recognize that this is a bug in our go-clients and have added it as a bug to fix in the future. We apologize for any inconvenience this brings you.

@caieo
Copy link
Contributor

caieo commented Aug 17, 2022

@averzicco, this should now be fixed as of v1.92.0. Please give it a try! I will close this issue for now, but feel free to open another issue if you find one.

@caieo caieo closed this as completed Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants