Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support denyMaintenancePeriod field in SQLInstance #637

Open
MoElkhidir opened this issue Mar 30, 2022 · 1 comment
Open

Support denyMaintenancePeriod field in SQLInstance #637

MoElkhidir opened this issue Mar 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@MoElkhidir
Copy link

Checklist

Bug Description

Exporting an imperative SqlInstnace resource using config-connector doesn't include DenyMaintenanceWindow in the yaml configuration output

Additional Diagnostic Information

Kubernetes Cluster Version

Client Version: v1.22.4
Server Version: v1.21.9-gke.1002

Config Connector Version

1.71.0

Steps to Reproduce

Steps to reproduce the issue

  1. Create a SqlInstnace using Cloud Console.
  2. Manually set the DenyMaintenancePeriod for the instance in the console.
  3. (optional) Use gcloud CLI to describe the imperative instance and save it.
  4. Use Config-Connector to export the instance to be declaratively imported.
  5. User Kubectl to import the instance to be declaratively managed.
  6. (optional) Use gcloud CLI to describe the now declaratively-managd instance and save it.
  7. Compare the two instance descriptions from 3 and 6 Or navigate to Google Cloud Console and observe for DenyMaintenancePeriods to have been removed.
@MoElkhidir MoElkhidir added the bug Something isn't working label Mar 30, 2022
@caieo
Copy link
Contributor

caieo commented Mar 31, 2022

Hi @moe-elkhidir, I'm going to actually mark this as an enhancement and not a bug because technically KCC is behaving as expected. It looks like the DenyMaintenancePeriod is a newer field that is not yet added in our CRD. In order to support this new field, we rely on Terraform adding it to their SQLInstance config. It looks like there is already an open issue here for it: hashicorp/terraform-provider-google#11287 . Feel free to chime in or 👍 that TF issue. Once the field is supported in TF, it should be a one or two week delay before it's added into KCC.

@caieo caieo added enhancement New feature or request and removed bug Something isn't working labels Mar 31, 2022
@caieo caieo changed the title Config-Connector doesn't support CloudSql instance denyMaintenancePeriods Support denyMaintenancePeriod field in SQLInstance Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants