BigTable GCPolicy Max Age Duration "d" (for days) is not working correctly

[joepeterson-bestbuy]

Checklist

• I did not find a related open issue.
• I did not find a solution in the troubleshooting guide: (https://cloud.google.com/config-connector/docs/troubleshooting)
• [] If this issue is time-sensitive, I have submitted a corresponding issue with GCP support.

Bug Description

When deploying a BigTable GCPolicy resource, and specifying a maxAge duration of "90d", the resource fails with the following error:
Warning UpdateFailed 11s (x5 over 5m47s) bigtablegcpolicy-controller Update call failed: error calculating diff: time: unknown unit "d" in duration "90d"

However, all other units including ms, s, m, h, appear to work just fine.

Additional Diagnostic Information

Kubernetes Cluster Version

Client Version: v1.19.4
Server Version: v1.20.10-gke.1600

Config Connector Version

1.70.0

Config Connector Mode

namespaced

[xiaobaitusi]

Hi @joepeterson-bestbuy, I think that the root cause is that the underlying terraform resource uses the time.ParseDuration() which doesn't support d time unit.

I would suggest to use h instead to unblock yourself now. If you really like to support d, do you mind creating an issue in https://github.com/hashicorp/terraform-provider-google-beta to surface the feature request?

[kevinsi4508]

This should be resolved by using gc_rules. Currently we are waiting for KCC to update to the latest Google Terraform Provider version.

[mbzomowski]

spec.gcRules has been added to BigTableGCPolicy as of Config Connector v1.97.0. We don't recommend using maxAge, maxVersion or mode for defining a
BigTableGCPolicy as these fields have known drift detection issues. Instead, please use gcRules