Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecretManagerSecret to include support for setting expiration and rotation policies #471

Closed
tedelwartowski-bestbuy opened this issue May 18, 2021 · 5 comments
Labels
enhancement New feature or request resource request

Comments

@tedelwartowski-bestbuy
Copy link

The GCP Secret Manager API supports the following which is not part of the SecretManagerSecret CRD:

  • Expiration policy attached to the Secret. If specified the Secret and all SecretVersions will be automatically deleted at expiration.
  • Rotation policy attached to the Secret.

Importance
This would be considered a pain-point as we are automating the creation of secrets and then have to manually update the secret to add a rotation notification or expiration.

@tedelwartowski-bestbuy tedelwartowski-bestbuy added the enhancement New feature or request label May 18, 2021
@spew
Copy link
Contributor

spew commented May 19, 2021

Hello @tedelwartowski-bestbuy thank you for your request. We are prioritizing this one internally and will have a future update.

@spew
Copy link
Contributor

spew commented May 24, 2021

Hello @tedelwartowski-bestbuy we are looking into prioritizing this, if this is very important in the near future for you can you work with your GCP account manager to file an issue. This will help raise the priority on our side.

@gameformush
Copy link

What about adding pub-sub topics notification? Great feature but can't be enabled with CRD hence not really usable for automation :(

@jcanseco
Copy link
Member

jcanseco commented Jun 4, 2021

Hi @gameformush, we'll track that one too.

SecretManagerSecret is one of our Terraform-based resources, so I've deferred to the Terraform team to add support for the missing fields. It seems that they already had an existing request to add these fields from their users: hashicorp/terraform-provider-google#9195.

Once they add support, we'll be able to bring them over to Config Connector.

@jcanseco
Copy link
Member

Hi @tedelwartowski-bestbuy and @gameformush, we just added support for the expire, rotation, topics, and ttl fields in SecretManagerSecret in KCC 1.56.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource request
Projects
None yet
Development

No branches or pull requests

4 participants