Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference sql user password from secret manager #297

Closed
zakare0 opened this issue Nov 3, 2020 · 5 comments
Closed

reference sql user password from secret manager #297

zakare0 opened this issue Nov 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@zakare0
Copy link

zakare0 commented Nov 3, 2020

Is there a way to reference a secret manager secret as an sql user password ?
that will be really helpful , to avoid creating a k8s secret
thanks in advance

@zakare0 zakare0 added the question Further information is requested label Nov 3, 2020
@jcanseco
Copy link
Member

Hi @ni-ezakaria, we currently don't have support for such a feature, but it is an idea that has come up before. I'll leave this issue open and mark it as an enhancement so that we can track this issue as a feature request.

Could you please elaborate on whether you consider this feature request a blocker, pain point, or nice-to-have?

Also, one thing to note is that if you're already using Config Connector to manage secret manager secrets, you could share the same K8s Secrets you reference in your SecretManagerSecretVersion resources with your SQLUser resources. I'm not sure if such a strategy would be sufficient for your use-case, but it's just an idea that I thought I'd throw out there.

@jcanseco jcanseco added enhancement New feature or request and removed question Further information is requested labels Nov 10, 2020
@jcanseco
Copy link
Member

jcanseco commented Nov 10, 2020

Also linking this issue to another related issue: Issue #272

Can you elaborate if the feature described above would also work for you? (i.e. have the SecretManagerSecret automatically create a K8s Secret that can be referenced from other resources like SQLUser so that you don't have to create a K8s Secret on your own).

@zakare0
Copy link
Author

zakare0 commented Nov 12, 2020

hi @jcanseco .. thanks for your feedback , i wold say it's a pain point ... however this approach of having the SecretManagerSecret automatically create a K8s Secret that can be referenced from other resources will do the trick.

@jcanseco
Copy link
Member

Gotcha, thanks for clarifying @ni-ezakaria.

@toumorokoshi
Copy link
Contributor

Hi! Closing this issue as a duplicate of #272. We'll be able to see this issue as an additional use case that should be satisfied by the final solution.

Thanks for raising the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants