Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to configure IAMPolicyMember via KCC #243

Closed
morgante opened this issue Jul 16, 2020 · 3 comments
Closed

Unable to configure IAMPolicyMember via KCC #243

morgante opened this issue Jul 16, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@morgante
Copy link

Describe the bug
I'm attempting to use KCC to set up the workload identity connection for new namespaces.

Specifically, I want to connect the KCC KSA (for a new namespace) to the GSA (for a new project) via KSA.

However, when using IAMPolicyMember to make this connection this error is returned:

 error setting policy member: error applying changes:
Error applying IAM policy for service account 'projects/clf-gke-acm-dev/serviceAccounts/clf-anthos-cicd-demo-cnrm@clf-gke-acm-dev.iam.gserviceaccount.com':
Error setting IAM policy for service account 'projects/clf-gke-acm-dev/serviceAccounts/clf-anthos-cicd-demo-cnrm@clf-gke-acm-dev.iam.gserviceaccount.com': googleapi:
Error 400: Invalid service account (clf-gke-acm-dev.svc.id.goog[cnrm-system/cnrm-controller-manager-clf-anthos-cicd-demo]")., badRequest

This is even though the equivalent gcloud works without error:

gcloud iam service-accounts add-iam-policy-binding \
    --role=roles/iam.workloadIdentityUser \
    --member="serviceAccount:clf-gke-acm-dev.svc.id.goog[cnrm-system/cnrm-controller-manager-clf-anthos-cicd-demo]" \
    clf-anthos-cicd-demo-cnrm@clf-gke-acm-dev.iam.gserviceaccount.com

A clear and concise description of what the bug is.

ConfigConnector Version
1.12.1

YAML snippets:

apiVersion: iam.cnrm.cloud.google.com/v1beta1
kind: IAMServiceAccount
metadata:
  namespace: cnrm-test
  name: clf-anthos-cicd-demo-cnrm # {"$ref":"#/definitions/io.k8s.cli.substitutions.sa-name"}
spec:
  displayName: clf-anthos-cicd-demo-cnrm # {"$ref":"#/definitions/io.k8s.cli.substitutions.sa-name"}
---
apiVersion: iam.cnrm.cloud.google.com/v1beta1
kind: IAMPolicyMember
metadata:
  namespace: cnrm-test
  name: clf-anthos-cicd-demo-cnrm # {"$ref":"#/definitions/io.k8s.cli.substitutions.sa-name"}
spec:
  member: "serviceAccount:clf-anthos-cicd-demo-cnrm@clf-gke-acm-dev.iam.gserviceaccount.com" # {"$ref":"#/definitions/io.k8s.cli.substitutions.sa-member"}
  role: roles/owner
  resourceRef:
    name: clf-anthos-cicd-demo # {"$ref":"#/definitions/io.k8s.cli.setters.project-id"}
    kind: Project
    apiVersion: resourcemanager.cnrm.cloud.google.com/v1beta1
---
apiVersion: iam.cnrm.cloud.google.com/v1beta1
kind: IAMPolicyMember
metadata:
  namespace: cnrm-test
  name: clf-anthos-cicd-demo-gsa-ksa # { "$kpt-set": "gsa-ksa-name" }
spec:
  member: serviceAccount:clf-gke-acm-dev.svc.id.goog[cnrm-system/cnrm-controller-manager-clf-anthos-cicd-demo]" # { "$kpt-set": "ksa-member" }
  role: roles/iam.workloadIdentityUser
  resourceRef:
    apiVersion: iam.cnrm.cloud.google.com/v1beta1
    kind: IAMServiceAccount
    name: clf-anthos-cicd-demo-cnrm # {"$ref":"#/definitions/io.k8s.cli.substitutions.sa-name"}
@morgante morgante added the bug Something isn't working label Jul 16, 2020
@jcanseco
Copy link
Member

Hi @morgante, I managed to get the scenario you described working.

Looking at your YAML snippets and error message, I believe the issue is that you had an extra quotation in the spec.member field of your second IAMPolicyMember.

Error 400: Invalid service account (clf-gke-acm-dev.svc.id.goog[cnrm-system/cnrm-controller-manager-clf-anthos-cicd-demo]")., badRequest
member: serviceAccount:clf-gke-acm-dev.svc.id.goog[cnrm-system/cnrm-controller-manager-clf-anthos-cicd-demo]" # { "$kpt-set": "ksa-member" }

Can you please verify that this was the issue?

@morgante
Copy link
Author

Oops. sorry I missed that! Yup that fixed it.

@jcanseco
Copy link
Member

No problem! Glad that fixed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants