Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for recovery/undelete projects #235

Open
anmoel opened this issue Jul 7, 2020 · 9 comments
Open

Support for recovery/undelete projects #235

anmoel opened this issue Jul 7, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@anmoel
Copy link

anmoel commented Jul 7, 2020

We need the possibility to restore projects. You get the following status if you create a manifest with Kind "Project" for a deleted project. It would be beneficial if a deleted project was recognized and then restored.

status:
  conditions:
  - lastTransitionTime: "2020-07-07T17:06:03Z"
    message: 'Update call failed: error applying desired state: error creating project
      dd-andre-test3-dev (dd-andre-test3-dev): googleapi: Error 409: Requested entity
      already exists, alreadyExists. If you received a 403 error, make sure you have
      the `roles/resourcemanager.projectCreator` permission'
    reason: UpdateFailed
    status: "False"
    type: Ready
@anmoel anmoel added the enhancement New feature or request label Jul 7, 2020
@maqiuyujoyce
Copy link
Collaborator

Hi @anmoel , thank you for your feedback. We'll look into it.

@maqiuyujoyce
Copy link
Collaborator

maqiuyujoyce commented Jul 10, 2020

Hi @anmoel , after some internal discussion, we determined that supporting recovery of deleted resources is out of the scope because the purpose of Config Connector is to make GCP resource management a Kubernetes native experience. In Kubernetes, deletions are really intended to be one-way. We recommend using gcloud if you need to recover your projects.

Additionally, "undeleting a project" is considered not part of the normal workflow, but only for emergency rollbacks. Could you provide more context about your scenario? Is there a reason you want to be able to recover the projects via Config Connector?

@anmoel
Copy link
Author

anmoel commented Jul 16, 2020

Hi @maqiuyujoyce,

we want to build packages like helm charts with config connector custom resources.
One of this packages creates a new project and activate all we need for a serverless application.
The ability to undelete projects would simplify the test pipelines.

@jcanseco
Copy link
Member

jcanseco commented Jul 17, 2020

Hey @anmoel, am I correct to understand that your intention is to, for each each test run, create a project with all the resources you need for the test using Config Connector? And that instead of actually creating a new project, you want to be able to undelete an old test project instead?

If my understanding above is correct, can you help me understand how being able to undelete projects would simplify your test pipelines?

@anmoel
Copy link
Author

anmoel commented Jul 28, 2020

Hello @jcanseco,

we are building helm charts, which we use to roll out project templates. Because of the google project limit we don't always want to create new projects but rather undelete a fixed project and create new resources in it.

At the moment we can only do an end to end test manually. the automated commit tests only generate the yaml files and compare them against an expected result.

Kind regards
André

@jcanseco
Copy link
Member

jcanseco commented Jul 28, 2020

Hi @anmoel, gotcha, that make sense. I can see how the project limit would cause issues.

Out of curiosity, is deleting the project a requirement, or would it be possible to abandon the test project and re-acquire it on subsequent test runs?

@anmoel
Copy link
Author

anmoel commented Jul 28, 2020

We are also testing the cleanup of helm charts in our manual started end to end test.

@jcanseco
Copy link
Member

I see, so if I am understanding this correctly, part of your tests test that cleanup of the Helm charts also deletes the GCP project?

@kibbles-n-bytes
Copy link
Contributor

@anmoel As part of your test flow, outside the helm chart, would it be reasonable to add a gcloud projects undelete call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants