diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6e5d5af91e..9bfeada5e5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -2,7 +2,7 @@ We'd love to accept your patches and contributions to this project. We use this GitHub project as our primary source of truth and the main development -repository for Config Connetor. The source code in this project is also +repository for Config Connector. The source code in this project is also mirrored to internal Google repository for the purposes of releases. ## Contributor License Agreement diff --git a/apis/bigquery/v1beta1/dataset_types.go b/apis/bigquery/v1beta1/dataset_types.go index 2c7ba3ec2d..c9174dfb64 100644 --- a/apis/bigquery/v1beta1/dataset_types.go +++ b/apis/bigquery/v1beta1/dataset_types.go @@ -42,7 +42,7 @@ type BigQueryDatasetSpec struct { // afterwards, and does not alter the existing tables. // The following values are supported: // - // * 'und:ci': undetermined locale, case insensitive. + // * 'und:ci': undetermined locale, case-insensitive. // * '': empty string. Default to case-sensitive behavior. DefaultCollation *string `json:"defaultCollation,omitempty"` diff --git a/apis/networkconnectivity/v1alpha1/types.generated.go b/apis/networkconnectivity/v1alpha1/types.generated.go index d10254d3f6..787bba3e2b 100644 --- a/apis/networkconnectivity/v1alpha1/types.generated.go +++ b/apis/networkconnectivity/v1alpha1/types.generated.go @@ -694,7 +694,7 @@ type ServiceConnectionMap struct { // Output only. The service class uri this ServiceConnectionMap is for. ServiceClassUri *string `json:"serviceClassUri,omitempty"` - // The token provided by the consumer. This token authenticates that the consumer can create a connecton within the specified project and network. + // The token provided by the consumer. This token authenticates that the consumer can create a connection within the specified project and network. Token *string `json:"token,omitempty"` // Output only. Time when the ServiceConnectionMap was updated. diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_bigquerydatasets.bigquery.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_bigquerydatasets.bigquery.cnrm.cloud.google.com.yaml index da0b043bbc..9f6813c02d 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_bigquerydatasets.bigquery.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_bigquerydatasets.bigquery.cnrm.cloud.google.com.yaml @@ -210,7 +210,7 @@ spec: afterwards, and does not alter the existing tables. The following values are supported: - * 'und:ci': undetermined locale, case insensitive. + * 'und:ci': undetermined locale, case-insensitive. * '': empty string. Default to case-sensitive behavior. type: string defaultEncryptionConfiguration: diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_computetargethttpsproxies.compute.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_computetargethttpsproxies.compute.cnrm.cloud.google.com.yaml index 060973b766..244af4a824 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_computetargethttpsproxies.compute.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_computetargethttpsproxies.compute.cnrm.cloud.google.com.yaml @@ -63,7 +63,7 @@ spec: description: |- URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer. Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED. - sslCertificates and certificateManagerCertificates fields can not be defined together. + sslCertificates and certificateManagerCertificates fields cannot be defined together. oneOf: - not: required: @@ -99,7 +99,7 @@ spec: can only be set for global target proxies. This field is only supported for EXTERNAL and EXTERNAL_MANAGED load balancing schemes. For INTERNAL_MANAGED, use certificateManagerCertificates instead. - sslCertificates and certificateMap fields can not be defined together. + sslCertificates and certificateMap fields cannot be defined together. oneOf: - not: required: diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml index 36d0c5999f..eeb6980193 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_discoveryenginedatastores.discoveryengine.cnrm.cloud.google.com.yaml @@ -242,7 +242,7 @@ spec: type: string defaultSchemaID: description: Output only. The id of the default [Schema][google.cloud.discoveryengine.v1.Schema] - asscociated to this data store. + associated to this data store. type: string type: object type: object diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iamauditconfigs.iam.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iamauditconfigs.iam.cnrm.cloud.google.com.yaml index b53f414dce..3ffed2b4cc 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iamauditconfigs.iam.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iamauditconfigs.iam.cnrm.cloud.google.com.yaml @@ -102,7 +102,7 @@ spec: ''allServices'' and a specific service, then the union of the two audit configs is used for that service: the ''logTypes'' specified in each ''auditLogConfig'' are enabled, and the ''exemptedMembers'' - in each ''auditLogConfg'' are exempted.' + in each ''auditLogConfig'' are exempted.' type: string required: - auditLogConfigs diff --git a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iampolicies.iam.cnrm.cloud.google.com.yaml b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iampolicies.iam.cnrm.cloud.google.com.yaml index e00c858b66..a8ff9d745a 100644 --- a/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iampolicies.iam.cnrm.cloud.google.com.yaml +++ b/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iampolicies.iam.cnrm.cloud.google.com.yaml @@ -92,7 +92,7 @@ spec: both ''allServices'' and a specific service, then the union of the two audit configs is used for that service: the ''logTypes'' specified in each ''auditLogConfig'' are enabled, and the - ''exemptedMembers'' in each ''auditLogConfg'' are exempted.' + ''exemptedMembers'' in each ''auditLogConfig'' are exempted.' type: string required: - auditLogConfigs diff --git a/config/servicemappings/compute.yaml b/config/servicemappings/compute.yaml index ad0cb7a769..1c4b5db4db 100644 --- a/config/servicemappings/compute.yaml +++ b/config/servicemappings/compute.yaml @@ -1637,7 +1637,7 @@ spec: targetField: name idTemplate: "projects/{{project}}/regions/{{region}}/networkEndpointGroups/{{name}}" idTemplateCanBeUsedToMatchResourceName: false - # TODO: (b/233123518) Config Connector CLI can not currently support ComputeRegionNetworkEndpointGroup. + # TODO: (b/233123518) Config Connector CLI cannot currently support ComputeRegionNetworkEndpointGroup. resourceAvailableInAssetInventory: false resourceReferences: - key: serviceRef @@ -2472,7 +2472,7 @@ spec: description: |- URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer. Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED. - sslCertificates and certificateManagerCertificates fields can not be defined together. + sslCertificates and certificateManagerCertificates fields cannot be defined together. gvk: kind: CertificateManagerCertificate version: v1beta1 @@ -2508,7 +2508,7 @@ spec: can only be set for global target proxies. This field is only supported for EXTERNAL and EXTERNAL_MANAGED load balancing schemes. For INTERNAL_MANAGED, use certificateManagerCertificates instead. - sslCertificates and certificateMap fields can not be defined together. + sslCertificates and certificateMap fields cannot be defined together. gvk: kind: CertificateManagerCertificateMap version: v1beta1 diff --git a/crds/bigquery_v1beta1_bigquerydataset.yaml b/crds/bigquery_v1beta1_bigquerydataset.yaml index 0f6e52c97a..4b1c36a5af 100644 --- a/crds/bigquery_v1beta1_bigquerydataset.yaml +++ b/crds/bigquery_v1beta1_bigquerydataset.yaml @@ -223,7 +223,7 @@ spec: afterwards, and does not alter the existing tables. The following values are supported: - * 'und:ci': undetermined locale, case insensitive. + * 'und:ci': undetermined locale, case-insensitive. * '': empty string. Default to case-sensitive behavior. type: string defaultEncryptionConfiguration: diff --git a/crds/bigquery_v1beta1_bigqueryjob.yaml b/crds/bigquery_v1beta1_bigqueryjob.yaml index 2861c31453..506709af2b 100644 --- a/crds/bigquery_v1beta1_bigqueryjob.yaml +++ b/crds/bigquery_v1beta1_bigqueryjob.yaml @@ -441,7 +441,7 @@ spec: projectionFields: description: |- Immutable. If sourceFormat is set to "DATASTORE_BACKUP", indicates which entity properties to load into BigQuery from a Cloud Datastore backup. - Property names are case sensitive and must be top-level properties. If no properties are specified, BigQuery loads all properties. + Property names are case-sensitive and must be top-level properties. If no properties are specified, BigQuery loads all properties. If any named property isn't found in the Cloud Datastore backup, an invalid error is returned in the job result. items: type: string diff --git a/crds/compute_v1beta1_computefirewallpolicy.yaml b/crds/compute_v1beta1_computefirewallpolicy.yaml index 32628ecbcd..a3c9d3411f 100644 --- a/crds/compute_v1beta1_computefirewallpolicy.yaml +++ b/crds/compute_v1beta1_computefirewallpolicy.yaml @@ -206,7 +206,7 @@ spec: type: integer ruleTupleCount: description: Total count of all firewall policy rule tuples. A firewall - policy can not exceed a set number of tuples. + policy cannot exceed a set number of tuples. format: int64 type: integer selfLink: diff --git a/crds/compute_v1beta1_computenetworkfirewallpolicy.yaml b/crds/compute_v1beta1_computenetworkfirewallpolicy.yaml index 71c54859dc..9742d39f7e 100644 --- a/crds/compute_v1beta1_computenetworkfirewallpolicy.yaml +++ b/crds/compute_v1beta1_computenetworkfirewallpolicy.yaml @@ -158,7 +158,7 @@ spec: type: integer ruleTupleCount: description: Total count of all firewall policy rule tuples. A firewall - policy can not exceed a set number of tuples. + policy cannot exceed a set number of tuples. type: integer selfLink: description: Server-defined URL for the resource. diff --git a/crds/compute_v1beta1_computetargethttpsproxy.yaml b/crds/compute_v1beta1_computetargethttpsproxy.yaml index 2149a69113..5027e5ecef 100644 --- a/crds/compute_v1beta1_computetargethttpsproxy.yaml +++ b/crds/compute_v1beta1_computetargethttpsproxy.yaml @@ -76,7 +76,7 @@ spec: description: |- URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer. Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED. - sslCertificates and certificateManagerCertificates fields can not be defined together. + sslCertificates and certificateManagerCertificates fields cannot be defined together. oneOf: - not: required: @@ -112,7 +112,7 @@ spec: can only be set for global target proxies. This field is only supported for EXTERNAL and EXTERNAL_MANAGED load balancing schemes. For INTERNAL_MANAGED, use certificateManagerCertificates instead. - sslCertificates and certificateMap fields can not be defined together. + sslCertificates and certificateMap fields cannot be defined together. oneOf: - not: required: diff --git a/crds/compute_v1beta1_computeurlmap.yaml b/crds/compute_v1beta1_computeurlmap.yaml index bd8c98a8bb..f08c16618b 100644 --- a/crds/compute_v1beta1_computeurlmap.yaml +++ b/crds/compute_v1beta1_computeurlmap.yaml @@ -1952,7 +1952,7 @@ spec: type: array ignoreCase: description: |- - Specifies that prefixMatch and fullPathMatch matches are case sensitive. + Specifies that prefixMatch and fullPathMatch matches are case-sensitive. Defaults to false. type: boolean metadataFilters: diff --git a/crds/datacatalog_v1alpha1_datacatalogentry.yaml b/crds/datacatalog_v1alpha1_datacatalogentry.yaml index c82bd0663b..fe609df924 100644 --- a/crds/datacatalog_v1alpha1_datacatalogentry.yaml +++ b/crds/datacatalog_v1alpha1_datacatalogentry.yaml @@ -154,7 +154,7 @@ spec: description: |- This field indicates the entry's source system that Data Catalog does not integrate with. userSpecifiedSystem strings must begin with a letter or underscore and can only contain letters, numbers, - and underscores; are case insensitive; must be at least 1 character and at most 64 characters long. + and underscores; are case-insensitive; must be at least 1 character and at most 64 characters long. type: string userSpecifiedType: description: |- @@ -162,7 +162,7 @@ spec: When creating an entry, users should check the enum values first, if nothing matches the entry to be created, then provide a custom value, for example "my_special_type". userSpecifiedType strings must begin with a letter or underscore and can only contain letters, - numbers, and underscores; are case insensitive; must be at least 1 character and at most 64 characters long. + numbers, and underscores; are case-insensitive; must be at least 1 character and at most 64 characters long. type: string required: - entryGroup diff --git a/crds/healthcare_v1alpha1_healthcarefhirstore.yaml b/crds/healthcare_v1alpha1_healthcarefhirstore.yaml index 273bfc2112..9efdf3e6c4 100644 --- a/crds/healthcare_v1alpha1_healthcarefhirstore.yaml +++ b/crds/healthcare_v1alpha1_healthcarefhirstore.yaml @@ -106,7 +106,7 @@ spec: type: boolean disableResourceVersioning: description: |- - Immutable. Whether to disable resource versioning for this FHIR store. This field can not be changed after the creation + Immutable. Whether to disable resource versioning for this FHIR store. This field cannot be changed after the creation of FHIR store. If set to false, which is the default behavior, all write operations will cause historical versions to be recorded automatically. The historical versions can be fetched through the history APIs, but cannot be updated. If set to true, no historical versions will be kept. The server will send back errors for diff --git a/crds/iam_v1beta1_iamauditconfig.yaml b/crds/iam_v1beta1_iamauditconfig.yaml index 77ba42ba7f..1ab3a59ee5 100644 --- a/crds/iam_v1beta1_iamauditconfig.yaml +++ b/crds/iam_v1beta1_iamauditconfig.yaml @@ -115,7 +115,7 @@ spec: ''allServices'' and a specific service, then the union of the two audit configs is used for that service: the ''logTypes'' specified in each ''auditLogConfig'' are enabled, and the ''exemptedMembers'' - in each ''auditLogConfg'' are exempted.' + in each ''auditLogConfig'' are exempted.' type: string required: - auditLogConfigs diff --git a/crds/iam_v1beta1_iampolicy.yaml b/crds/iam_v1beta1_iampolicy.yaml index 4cdfd26b7e..1bb97131bc 100644 --- a/crds/iam_v1beta1_iampolicy.yaml +++ b/crds/iam_v1beta1_iampolicy.yaml @@ -105,7 +105,7 @@ spec: both ''allServices'' and a specific service, then the union of the two audit configs is used for that service: the ''logTypes'' specified in each ''auditLogConfig'' are enabled, and the - ''exemptedMembers'' in each ''auditLogConfg'' are exempted.' + ''exemptedMembers'' in each ''auditLogConfig'' are exempted.' type: string required: - auditLogConfigs diff --git a/crds/memcache_v1beta1_memcacheinstance.yaml b/crds/memcache_v1beta1_memcacheinstance.yaml index 1aa29b3427..f237bacd9d 100644 --- a/crds/memcache_v1beta1_memcacheinstance.yaml +++ b/crds/memcache_v1beta1_memcacheinstance.yaml @@ -284,7 +284,7 @@ spec: scheduleDeadlineTime: description: |- Output only. The deadline that the maintenance schedule start time - can not go beyond, including reschedule. + cannot go beyond, including reschedule. A timestamp in RFC3339 UTC "Zulu" format, with nanosecond resolution and up to nine fractional digits. type: string diff --git a/crds/networkservices_v1alpha1_networkservicesedgecacheservice.yaml b/crds/networkservices_v1alpha1_networkservicesedgecacheservice.yaml index 6efa91e49a..bed11b5ba6 100644 --- a/crds/networkservices_v1alpha1_networkservicesedgecacheservice.yaml +++ b/crds/networkservices_v1alpha1_networkservicesedgecacheservice.yaml @@ -350,7 +350,7 @@ spec: type: array ignoreCase: description: Specifies that prefixMatch and - fullPathMatch matches are case sensitive. + fullPathMatch matches are case-sensitive. type: boolean pathTemplateMatch: description: |- @@ -537,8 +537,8 @@ spec: Cookie names: - must be valid RFC 6265 "cookie-name" tokens - - are case sensitive - - cannot start with "Edge-Cache-" (case insensitive) + - are case-sensitive + - cannot start with "Edge-Cache-" (case-insensitive) Note that specifying several cookies, and/or cookies that have a large range of values (e.g., per-user) will dramatically impact the cache hit rate, and may result in a higher eviction rate and reduced performance. @@ -551,7 +551,7 @@ spec: Names of HTTP request headers to include in cache keys. The value of the header field will be used as part of the cache key. - Header names must be valid HTTP RFC 7230 header field values. - - Header field names are case insensitive + - Header field names are case-insensitive - To include the HTTP method, use ":method" Note that specifying several headers, and/or headers that have a large range of values (e.g. per-user) will dramatically impact the cache hit rate, and may result in a higher eviction rate and reduced performance. diff --git a/crds/networkservices_v1beta1_networkservicesgateway.yaml b/crds/networkservices_v1beta1_networkservicesgateway.yaml index 4c1f526b07..017f634931 100644 --- a/crds/networkservices_v1beta1_networkservicesgateway.yaml +++ b/crds/networkservices_v1beta1_networkservicesgateway.yaml @@ -133,7 +133,7 @@ spec: description: Immutable. Required. Immutable. Scope determines how configuration across multiple Gateway instances are merged. The configuration for multiple Gateway instances with the same scope - will be merged as presented as a single coniguration to the proxy/load + will be merged as presented as a single configuration to the proxy/load balancer. Max length 64 characters. Scope should start with a letter and can only have letters, numbers, hyphens. type: string diff --git a/crds/networkservices_v1beta1_networkservicesgrpcroute.yaml b/crds/networkservices_v1beta1_networkservicesgrpcroute.yaml index d220f4ea46..4a50ac0e3f 100644 --- a/crds/networkservices_v1beta1_networkservicesgrpcroute.yaml +++ b/crds/networkservices_v1beta1_networkservicesgrpcroute.yaml @@ -384,7 +384,7 @@ spec: properties: caseSensitive: description: Optional. Specifies that matches are - case sensitive. The default value is true. case_sensitive + case-sensitive. The default value is true. case_sensitive must not be used with a type of REGULAR_EXPRESSION. type: boolean grpcMethod: diff --git a/crds/networkservices_v1beta1_networkserviceshttproute.yaml b/crds/networkservices_v1beta1_networkserviceshttproute.yaml index 7a2e313806..a2a3931cb5 100644 --- a/crds/networkservices_v1beta1_networkserviceshttproute.yaml +++ b/crds/networkservices_v1beta1_networkserviceshttproute.yaml @@ -359,7 +359,7 @@ spec: pathRedirect: description: The path that will be used in the redirect response instead of the one that was supplied in the - request. path_redirect can not be supplied together + request. path_redirect cannot be supplied together with prefix_redirect. Supply one alone or neither. If neither is supplied, the path of the original request will be used for the redirect. @@ -626,7 +626,7 @@ spec: type: array ignoreCase: description: Specifies if prefix_match and full_path_match - matches are case sensitive. The default value is false. + matches are case-sensitive. The default value is false. type: boolean prefixMatch: description: The HTTP request path value must begin with diff --git a/crds/redis_v1beta1_redisinstance.yaml b/crds/redis_v1beta1_redisinstance.yaml index 15c2d6336d..a10d9f5b2c 100644 --- a/crds/redis_v1beta1_redisinstance.yaml +++ b/crds/redis_v1beta1_redisinstance.yaml @@ -255,7 +255,7 @@ spec: scheduleDeadlineTime: description: |- Output only. The deadline that the maintenance schedule start time - can not go beyond, including reschedule. + cannot go beyond, including reschedule. A timestamp in RFC3339 UTC "Zulu" format, with nanosecond resolution and up to nine fractional digits. type: string @@ -433,7 +433,7 @@ spec: scheduleDeadlineTime: description: |- Output only. The deadline that the maintenance schedule start time - can not go beyond, including reschedule. + cannot go beyond, including reschedule. A timestamp in RFC3339 UTC "Zulu" format, with nanosecond resolution and up to nine fractional digits. type: string diff --git a/docs/develop-resources/api-conventions/external-reference.md b/docs/develop-resources/api-conventions/external-reference.md index 884827b413..847cba6025 100644 --- a/docs/develop-resources/api-conventions/external-reference.md +++ b/docs/develop-resources/api-conventions/external-reference.md @@ -44,7 +44,7 @@ The `status.externalRef` shall use the [cloud asset inventory](https://cloud.go * If user specifies the service-generated ID in the `spec.resourceID` field, the Direct reconciler will acquire the resource if the `status.externalRef` is not assigned. -### Backward compatibiltiy for TF/DCL based reconcilers +### Backward compatibility for TF/DCL based reconcilers The existing TF-based and DCL-based reconciliation treats the `spec.resourceID` as the single Source of Truth to identify a GCP resource. It writes back the `spec.resourceID` after reconciliation. Here are [the known problems](https://github.com/GoogleCloudPlatform/k8s-config-connector/issues/2765). Config Connector will keep the bahavior of these resources, until they are migrated to the Direct reconciler. diff --git a/docs/features/pause.md b/docs/features/pause.md index c2b758dac7..cba036912e 100644 --- a/docs/features/pause.md +++ b/docs/features/pause.md @@ -11,7 +11,7 @@ debugging purposes or to have a hot standby. We extended the API definitions for the Config Connector and Config ConnectorContext resources to support a new field, `spec.actuationMode`. The field's current supported values are `Reconciling` -and `Paused` with `Reconciling` being the default for backwards compatiblity. +and `Paused` with `Reconciling` being the default for backwards compatibility. As such, KCC can be "paused" both globally and on a per-namespace level if running in namespace mode ### Pausing Globally diff --git a/experiments/compositions/Design Notes/Architecture.md b/experiments/compositions/Design Notes/Architecture.md index b5518f2c1a..93649a953a 100644 --- a/experiments/compositions/Design Notes/Architecture.md +++ b/experiments/compositions/Design Notes/Architecture.md @@ -48,4 +48,4 @@ CRD_V/CRD_P ---> | | ---> [APPLIER JOB] --> apply to cluster ---> [KCC For POC we are using `Compositions` as the CRD_T (dry CRD). We will have a Composition controller that will reconcile Composition instance. It will also watch the CRD_V (Config/Value CRDs) that correspond to each instance of Composition. -For POC we could club the Compistion and Applier functionality into a single controller. \ No newline at end of file +For POC we could club the Composition and Applier functionality into a single controller. \ No newline at end of file diff --git a/experiments/compositions/Design Notes/Controller Runtime and Dynamic Controllers.md b/experiments/compositions/Design Notes/Controller Runtime and Dynamic Controllers.md index 92a6e343d1..e5a273f061 100644 --- a/experiments/compositions/Design Notes/Controller Runtime and Dynamic Controllers.md +++ b/experiments/compositions/Design Notes/Controller Runtime and Dynamic Controllers.md @@ -36,7 +36,7 @@ Multiple runnables share the same cancelable context. ## No support for checking if a controller/reconciler exists -contorller-runtime's Manager interface provides no way to check if a controller has been created for an given CRD(gvk). +controller-runtime's Manager interface provides no way to check if a controller has been created for an given CRD(gvk). `type Manager interface {}` : https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/manager/manager.go#L55 `type Cluster interface {}` : https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/cluster/cluster.go#L40 @@ -45,7 +45,7 @@ We would need to build an intrerface on top of the manager that supports checkin ## No support for stopping a controller -contorller-runtime's Manager interface provides no way to `Stop` or `Remove` a runnable. In fact it does not even track the runnables for a given group. During `Add()` a go routine is created and thats it. A shared cancellable context is used across multiple reconcilers. +controller-runtime's Manager interface provides no way to `Stop` or `Remove` a runnable. In fact it does not even track the runnables for a given group. During `Add()` a go routine is created and thats it. A shared cancellable context is used across multiple reconcilers. ## Impact for Allotrope - With naive controller-runtime library we end up starting multiple reconcilers for the same Input GVK everytime the Composition object changes. diff --git a/experiments/compositions/Design Notes/Deletion of Expanded Resources.md b/experiments/compositions/Design Notes/Deletion of Expanded Resources.md index 9f1a2e7100..385bbdf5ac 100644 --- a/experiments/compositions/Design Notes/Deletion of Expanded Resources.md +++ b/experiments/compositions/Design Notes/Deletion of Expanded Resources.md @@ -25,7 +25,7 @@ reference: - https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/83bd9c05741b108dc854a6b42bf893997b76d090/pkg/patterns/declarative/reconciler.go#L687 - https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/experiments/compositions/composition/internal/controller/expander_applier.go#L137 -## Abandon chioce +## Abandon choice We should allow the choice to abandon the expanded resources when the Input API is deleted. This could be done via an annotaton on the Input API object. diff --git a/experiments/compositions/Design Notes/Using Object Storage for manifests.md b/experiments/compositions/Design Notes/Using Object Storage for manifests.md index 7201fd2922..29316661e8 100644 --- a/experiments/compositions/Design Notes/Using Object Storage for manifests.md +++ b/experiments/compositions/Design Notes/Using Object Storage for manifests.md @@ -1,6 +1,6 @@ # Object storage for manifests -The object location (path) is created by the Allotrope Manager and then passed on to the Expander pods as part of the pod bringup. +The object location (path) is created by the Allotrope Manager and then passed on to the Expander pods as part of the pod bring-up. The expander pods should read the manifests from that location and then expand them and write it back to the same location. ## Object Storage provider diff --git a/experiments/compositions/composition/internal/controller/composition_controller.go b/experiments/compositions/composition/internal/controller/composition_controller.go index 6483616cfe..d856852e0b 100644 --- a/experiments/compositions/composition/internal/controller/composition_controller.go +++ b/experiments/compositions/composition/internal/controller/composition_controller.go @@ -118,7 +118,7 @@ func (r *CompositionReconciler) Reconcile(ctx context.Context, req ctrl.Request) logger = logger.WithName(composition.Name).WithName(fmt.Sprintf("%d", composition.Generation)) composition.Status.ClearCondition(compositionv1alpha1.Error) - logger.Info("Validating Compostion object") + logger.Info("Validating Composition object") if !composition.Validate() { logger.Info("Validation Failed") return ctrl.Result{}, fmt.Errorf("Validation failed") diff --git a/experiments/compositions/composition/tests/cluster/cluster.go b/experiments/compositions/composition/tests/cluster/cluster.go index ce1f1fe0e0..f529004b9e 100644 --- a/experiments/compositions/composition/tests/cluster/cluster.go +++ b/experiments/compositions/composition/tests/cluster/cluster.go @@ -109,7 +109,7 @@ func CreateKindClusters(clusterCount int, images string) { }, ) - // Bringup the cluster and install the operator + // Bring up the cluster and install the operator err := kc.ClusterUp() if err != nil { log.Fatalf("Error creating kind cluster: %s, %v", name, err) @@ -155,7 +155,7 @@ func CreateCCClusters(clusterCount int, images string) { }, ) - // Bringup the cluster and install the operator + // Bring up the cluster and install the operator err := cc.ClusterUp() if err != nil { log.Fatalf("Error creating CC cluster: %s, %v", name, err) diff --git a/experiments/compositions/composition/tests/data/TestSimplePlanStatusErrorFailedApplyingManifests/input.yaml b/experiments/compositions/composition/tests/data/TestSimplePlanStatusErrorFailedApplyingManifests/input.yaml index f54aaac5c4..3582380c31 100644 --- a/experiments/compositions/composition/tests/data/TestSimplePlanStatusErrorFailedApplyingManifests/input.yaml +++ b/experiments/compositions/composition/tests/data/TestSimplePlanStatusErrorFailedApplyingManifests/input.yaml @@ -133,7 +133,7 @@ spec: name: common template: | apiVersion: v1 - kind: MonfigCap ## should fail + kind: ConfigCap_ ## should fail metadata: name: common-config namespace: {{ pconfigs.metadata.namespace }} diff --git a/experiments/compositions/samples/AttachedAKS/aks-charlie.md b/experiments/compositions/samples/AttachedAKS/aks-charlie.md index 894b771cc3..cda1e893e2 100644 --- a/experiments/compositions/samples/AttachedAKS/aks-charlie.md +++ b/experiments/compositions/samples/AttachedAKS/aks-charlie.md @@ -1,4 +1,4 @@ -## Apply the compostion +## Apply the composition ``` kubectl apply -f 01-composition.yaml ``` diff --git a/experiments/compositions/samples/AttachedEKS/eks-charlie.md b/experiments/compositions/samples/AttachedEKS/eks-charlie.md index 336120a7cb..f931b098bf 100644 --- a/experiments/compositions/samples/AttachedEKS/eks-charlie.md +++ b/experiments/compositions/samples/AttachedEKS/eks-charlie.md @@ -1,4 +1,4 @@ -## Apply the compostion +## Apply the composition kubectl apply -f 01-composition.yaml diff --git a/mockgcp/apis/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.proto b/mockgcp/apis/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.proto index 23fb72cc33..5a278d9263 100644 --- a/mockgcp/apis/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.proto +++ b/mockgcp/apis/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.proto @@ -690,7 +690,7 @@ message InterconnectAttachment { string region = 1 [json_name="region"]; } -// The internal range resource for IPAM operations within a VPC network. Used to represent a private address range along with behavioral characterstics of that range (its usage and peering behavior). Networking resources can link to this range if they are created as belonging to it. +// The internal range resource for IPAM operations within a VPC network. Used to represent a private address range along with behavioral characteristics of that range (its usage and peering behavior). Networking resources can link to this range if they are created as belonging to it. message InternalRange { // Time when the internal range was created. .google.protobuf.Timestamp create_time = 1 [json_name="createTime"]; @@ -1281,7 +1281,7 @@ message ServiceConnectionMap { string service_class = 10 [json_name="serviceClass"]; // Output only. The service class uri this ServiceConnectionMap is for. string service_class_uri = 11 [json_name="serviceClassUri"]; - // The token provided by the consumer. This token authenticates that the consumer can create a connecton within the specified project and network. + // The token provided by the consumer. This token authenticates that the consumer can create a connection within the specified project and network. string token = 12 [json_name="token"]; // Output only. Time when the ServiceConnectionMap was updated. .google.protobuf.Timestamp update_time = 13 [json_name="updateTime"]; diff --git a/mockgcp/common/httpmux/errors.go b/mockgcp/common/httpmux/errors.go index e1492f898e..9280d270a1 100644 --- a/mockgcp/common/httpmux/errors.go +++ b/mockgcp/common/httpmux/errors.go @@ -42,7 +42,7 @@ type ErrorResponseDetails struct { Reason string `json:"reason,omitempty"` } -// customErrorHandler wraps errors in an error blockk +// customErrorHandler wraps errors in an error block func (m *ServeMux) customErrorHandler(ctx context.Context, mux *runtime.ServeMux, marshaler runtime.Marshaler, w http.ResponseWriter, r *http.Request, err error) { s := status.Convert(err) // pb := s.Proto() diff --git a/mockgcp/generated/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.pb.go b/mockgcp/generated/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.pb.go index a37560793c..9781b374b8 100644 --- a/mockgcp/generated/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.pb.go +++ b/mockgcp/generated/mockgcp/cloud/networkconnectivity/v1/networkconnectivity.pb.go @@ -4551,7 +4551,7 @@ type ServiceConnectionMap struct { ServiceClass string `protobuf:"bytes,10,opt,name=service_class,json=serviceClass,proto3" json:"service_class,omitempty"` // Output only. The service class uri this ServiceConnectionMap is for. ServiceClassUri string `protobuf:"bytes,11,opt,name=service_class_uri,json=serviceClassUri,proto3" json:"service_class_uri,omitempty"` - // The token provided by the consumer. This token authenticates that the consumer can create a connecton within the specified project and network. + // The token provided by the consumer. This token authenticates that the consumer can create a connection within the specified project and network. Token string `protobuf:"bytes,12,opt,name=token,proto3" json:"token,omitempty"` // Output only. Time when the ServiceConnectionMap was updated. UpdateTime *timestamp.Timestamp `protobuf:"bytes,13,opt,name=update_time,json=updateTime,proto3" json:"update_time,omitempty"` diff --git a/operator/config/crd/bases/core.cnrm.cloud.google.com_configconnectors.yaml b/operator/config/crd/bases/core.cnrm.cloud.google.com_configconnectors.yaml index cfc7772679..bb27a12308 100644 --- a/operator/config/crd/bases/core.cnrm.cloud.google.com_configconnectors.yaml +++ b/operator/config/crd/bases/core.cnrm.cloud.google.com_configconnectors.yaml @@ -54,7 +54,7 @@ spec: This can be either 'Reconciling' or 'Paused'. In 'Paused', k8s resources are still reconciled with the api server but not actuated onto the cloud provider. If Config Connector is running in 'namespaced' mode, then the value in ConfigConnectorContext (CCC) takes precedence. - If CCC doesn't define a value but ConfigConnecor (CC) does, we defer to that value. Otherwise, + If CCC doesn't define a value but ConfigConnector (CC) does, we defer to that value. Otherwise, the default is 'Reconciling' where resources get actuated. enum: - Reconciling diff --git a/operator/pkg/apis/core/v1beta1/configconnector_types.go b/operator/pkg/apis/core/v1beta1/configconnector_types.go index 3837de39dc..9b0b948382 100644 --- a/operator/pkg/apis/core/v1beta1/configconnector_types.go +++ b/operator/pkg/apis/core/v1beta1/configconnector_types.go @@ -45,7 +45,7 @@ type ConfigConnectorSpec struct { // This can be either 'Reconciling' or 'Paused'. // In 'Paused', k8s resources are still reconciled with the api server but not actuated onto the cloud provider. // If Config Connector is running in 'namespaced' mode, then the value in ConfigConnectorContext (CCC) takes precedence. - // If CCC doesn't define a value but ConfigConnecor (CC) does, we defer to that value. Otherwise, + // If CCC doesn't define a value but ConfigConnector (CC) does, we defer to that value. Otherwise, // the default is 'Reconciling' where resources get actuated. //+kubebuilder:validation:Enum=Reconciling;Paused //+kubebuilder:validation:Optional diff --git a/pkg/apis/iam/v1beta1/iamauditconfig_types.go b/pkg/apis/iam/v1beta1/iamauditconfig_types.go index 4c5bc1c150..c4482ddde7 100644 --- a/pkg/apis/iam/v1beta1/iamauditconfig_types.go +++ b/pkg/apis/iam/v1beta1/iamauditconfig_types.go @@ -33,7 +33,7 @@ type IAMAuditConfigSpec struct { // Note that if there are audit configs covering both 'allServices' and // a specific service, then the union of the two audit configs is used // for that service: the 'logTypes' specified in each 'auditLogConfig' - // are enabled, and the 'exemptedMembers' in each 'auditLogConfg' are + // are enabled, and the 'exemptedMembers' in each 'auditLogConfig' are // exempted. Service string `json:"service"` // Required. The configuration for logging of each type of permission. diff --git a/pkg/apis/iam/v1beta1/iampolicy_types.go b/pkg/apis/iam/v1beta1/iampolicy_types.go index 0d01c82ab6..a1bc02095e 100644 --- a/pkg/apis/iam/v1beta1/iampolicy_types.go +++ b/pkg/apis/iam/v1beta1/iampolicy_types.go @@ -43,7 +43,7 @@ type IAMPolicyAuditConfig struct { // audit configs covering both 'allServices' and a specific service, then // the union of the two audit configs is used for that service: the // 'logTypes' specified in each 'auditLogConfig' are enabled, and the - // 'exemptedMembers' in each 'auditLogConfg' are exempted. + // 'exemptedMembers' in each 'auditLogConfig' are exempted. Service string `json:"service"` // Required. The configuration for logging of each type of permission. AuditLogConfigs []AuditLogConfig `json:"auditLogConfigs"` diff --git a/pkg/cli/cmd/apply/parameters/parameters.go b/pkg/cli/cmd/apply/parameters/parameters.go index 9af9f2c78f..70caae61e2 100644 --- a/pkg/cli/cmd/apply/parameters/parameters.go +++ b/pkg/cli/cmd/apply/parameters/parameters.go @@ -44,7 +44,7 @@ func Validate(p *Parameters, stdin *os.File) error { } } if valutil.IsDefaultValue(inputFile) { - return fmt.Errorf("'%v' parameter can not be empty", InputParam) + return fmt.Errorf("'%v' parameter cannot be empty", InputParam) } return nil } diff --git a/pkg/clients/generated/apis/bigquery/v1beta1/bigquerydataset_types.go b/pkg/clients/generated/apis/bigquery/v1beta1/bigquerydataset_types.go index 6daf84acb5..e0c8595d5d 100644 --- a/pkg/clients/generated/apis/bigquery/v1beta1/bigquerydataset_types.go +++ b/pkg/clients/generated/apis/bigquery/v1beta1/bigquerydataset_types.go @@ -139,7 +139,7 @@ type BigQueryDatasetSpec struct { afterwards, and does not alter the existing tables. The following values are supported: - * 'und:ci': undetermined locale, case insensitive. + * 'und:ci': undetermined locale, case-insensitive. * '': empty string. Default to case-sensitive behavior. */ // +optional DefaultCollation *string `json:"defaultCollation,omitempty"` diff --git a/pkg/clients/generated/apis/compute/v1beta1/computetargethttpsproxy_types.go b/pkg/clients/generated/apis/compute/v1beta1/computetargethttpsproxy_types.go index d7884fae20..42c1107e77 100644 --- a/pkg/clients/generated/apis/compute/v1beta1/computetargethttpsproxy_types.go +++ b/pkg/clients/generated/apis/compute/v1beta1/computetargethttpsproxy_types.go @@ -44,7 +44,7 @@ type ComputeTargetHTTPSProxySpec struct { can only be set for global target proxies. This field is only supported for EXTERNAL and EXTERNAL_MANAGED load balancing schemes. For INTERNAL_MANAGED, use certificateManagerCertificates instead. - sslCertificates and certificateMap fields can not be defined together. */ + sslCertificates and certificateMap fields cannot be defined together. */ // +optional CertificateMapRef *v1alpha1.ResourceRef `json:"certificateMapRef,omitempty"` diff --git a/pkg/clients/generated/apis/iam/v1beta1/iamauditconfig_types.go b/pkg/clients/generated/apis/iam/v1beta1/iamauditconfig_types.go index e4ea757232..5158efabb4 100644 --- a/pkg/clients/generated/apis/iam/v1beta1/iamauditconfig_types.go +++ b/pkg/clients/generated/apis/iam/v1beta1/iamauditconfig_types.go @@ -51,7 +51,7 @@ type IAMAuditConfigSpec struct { /* Immutable. Required. The GCP resource to set the IAMAuditConfig on (e.g. project). */ ResourceRef v1alpha1.IAMResourceRef `json:"resourceRef"` - /* Immutable. Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfg' are exempted. */ + /* Immutable. Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfig' are exempted. */ Service string `json:"service"` } diff --git a/pkg/clients/generated/apis/iam/v1beta1/iampolicy_types.go b/pkg/clients/generated/apis/iam/v1beta1/iampolicy_types.go index c0ce6ddd05..3e88244a8b 100644 --- a/pkg/clients/generated/apis/iam/v1beta1/iampolicy_types.go +++ b/pkg/clients/generated/apis/iam/v1beta1/iampolicy_types.go @@ -39,7 +39,7 @@ type PolicyAuditConfigs struct { /* Required. The configuration for logging of each type of permission. */ AuditLogConfigs []PolicyAuditLogConfigs `json:"auditLogConfigs"` - /* Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfg' are exempted. */ + /* Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfig' are exempted. */ Service string `json:"service"` } diff --git a/pkg/controller/direct/dataform/repository_controller.go b/pkg/controller/direct/dataform/repository_controller.go index dfbd9ec01c..f33344954c 100644 --- a/pkg/controller/direct/dataform/repository_controller.go +++ b/pkg/controller/direct/dataform/repository_controller.go @@ -249,7 +249,7 @@ func (a *Adapter) Update(ctx context.Context, updateOp *directbase.UpdateOperati mapCtx := &direct.MapContext{} protoDesired := RepositoryWorkspaceCompilationOverrides_ToProto(mapCtx, a.desired.Spec.WorkspaceCompilationOverrides) if mapCtx.Err() != nil { - return fmt.Errorf("converting WorkspaceCompilaitonOverrides to api: %w", mapCtx.Err()) + return fmt.Errorf("converting WorkspaceCompilationOverrides to api: %w", mapCtx.Err()) } if !reflect.DeepEqual(protoDesired, a.actual.WorkspaceCompilationOverrides) { diff --git a/pkg/controller/resourceactuation/resourceactuation.go b/pkg/controller/resourceactuation/resourceactuation.go index 1c1064eb1a..34f56c224b 100644 --- a/pkg/controller/resourceactuation/resourceactuation.go +++ b/pkg/controller/resourceactuation/resourceactuation.go @@ -81,7 +81,7 @@ func ShouldSkip(u *unstructured.Unstructured) (bool, error) { for _, condition := range conditions { conditionMap, ok := condition.(map[string]interface{}) if !ok { - return false, fmt.Errorf("error coverting condition %v to map", condition) + return false, fmt.Errorf("error converting condition %v to map", condition) } if status, foundStatus := conditionMap["status"].(string); foundStatus && status == "True" { if reason, foundCondition := conditionMap["reason"].(string); foundCondition && reason == k8s.UpToDate { diff --git a/pkg/dcl/references_test.go b/pkg/dcl/references_test.go index eb056cd4e1..4d32bcfd87 100644 --- a/pkg/dcl/references_test.go +++ b/pkg/dcl/references_test.go @@ -102,7 +102,7 @@ func TestToTypeConfig(t *testing.T) { res, err := dcl.ToTypeConfig(tc.dclRefExtensionElem, smLoader) if tc.hasError { if err == nil { - t.Fatalf("got nil, but expect to get an error on converting to TypeConifg") + t.Fatalf("got nil, but expect to get an error on converting to TypeConfig") } return } diff --git a/pkg/krmtotf/references_test.go b/pkg/krmtotf/references_test.go index af264ad631..b3fa6fdeaa 100644 --- a/pkg/krmtotf/references_test.go +++ b/pkg/krmtotf/references_test.go @@ -1751,7 +1751,7 @@ func TestIsHierarchicalReference(t *testing.T) { { name: "resource reference is not one of hierarchical references", ref: corekccv1alpha1.ReferenceConfig{ - TFField: "biling", + TFField: "billing", TypeConfig: corekccv1alpha1.TypeConfig{ Key: "billingRef", GVK: schema.GroupVersionKind{ diff --git a/pkg/resourceskeleton/resourceskeleton.go b/pkg/resourceskeleton/resourceskeleton.go index e98b49472a..0b24ac791f 100644 --- a/pkg/resourceskeleton/resourceskeleton.go +++ b/pkg/resourceskeleton/resourceskeleton.go @@ -93,7 +93,7 @@ func NewFromAsset(a *asset.Asset, smLoader *servicemappingloader.ServiceMappingL name := trimServiceHostName(a, sm) importID, err := convertAssetNameToImportID(rc, name) if err != nil { - return nil, fmt.Errorf("error coverting cloud asset inventory name '%v' to resource id: %w", name, err) + return nil, fmt.Errorf("error converting cloud asset inventory name '%v' to resource id: %w", name, err) } state, err := krmtotf.ImportState(context.Background(), importID, &tfInfo, tfProvider) if err != nil { diff --git a/pkg/resourceskeleton/testdata/asset-skeleton.yaml b/pkg/resourceskeleton/testdata/asset-skeleton.yaml index dacb4f31a8..964513839a 100644 --- a/pkg/resourceskeleton/testdata/asset-skeleton.yaml +++ b/pkg/resourceskeleton/testdata/asset-skeleton.yaml @@ -462,7 +462,7 @@ - resourceConfigId: ComputeNodeTemplate # not supported by asset inventory - resourceConfigId: ComputeProjectMetadata -# TODO: (b/233123518) Config Connector CLI can not currently support ComputeRegionNetworkEndpointGroup. +# TODO: (b/233123518) Config Connector CLI cannot currently support ComputeRegionNetworkEndpointGroup. - resourceConfigId: ComputeRegionNetworkEndpointGroup # not supported by asset inventory - resourceConfigId: ComputeReservation diff --git a/pkg/resourceskeleton/testdata/uri-skeleton.yaml b/pkg/resourceskeleton/testdata/uri-skeleton.yaml index c4d64b5b60..1284e82de2 100644 --- a/pkg/resourceskeleton/testdata/uri-skeleton.yaml +++ b/pkg/resourceskeleton/testdata/uri-skeleton.yaml @@ -394,7 +394,7 @@ - ExpectedSkeleton: null ResourceConfigId: ComputeRegionNetworkEndpointGroup URI: "" - # TODO: (b/233123518) Config Connector CLI can not currently support ComputeRegionNetworkEndpointGroup. + # TODO: (b/233123518) Config Connector CLI cannot currently support ComputeRegionNetworkEndpointGroup. - ExpectedSkeleton: apiVersion: compute.cnrm.cloud.google.com/v1beta1 kind: ComputeReservation diff --git a/pkg/test/http_recorder.go b/pkg/test/http_recorder.go index fd5cb8df43..7d40dfb590 100644 --- a/pkg/test/http_recorder.go +++ b/pkg/test/http_recorder.go @@ -264,7 +264,7 @@ func (r *Response) AddHeader(key, value string) { func (r *Response) RemoveHeader(key string) { // The http.header `Del` converts the `key` to `CanonicalHeaderKey`, which means - // it expects the passed-in parameter `key` to be case insensitive, but `Header` itself should + // it expects the passed-in parameter `key` to be case-insensitive, but `Header` itself should // use canonical keys. r.Header.Del(key) // Delete non canonical header keys like `x-goog-api-client`. @@ -273,7 +273,7 @@ func (r *Response) RemoveHeader(key string) { func (r *Request) RemoveHeader(key string) { // The http.header `Del` converts the `key` to `CanonicalHeaderKey`, which means - // it expects the passed-in parameter `key` to be case insensitive, but `Header` itself should + // it expects the passed-in parameter `key` to be case-insensitive, but `Header` itself should // use canonical keys. r.Header.Del(key) // Delete non canonical header keys like `x-goog-api-client`. diff --git a/scripts/cluster-troubleshoot.sh b/scripts/cluster-troubleshoot.sh index ad007c93f4..a141fb32eb 100755 --- a/scripts/cluster-troubleshoot.sh +++ b/scripts/cluster-troubleshoot.sh @@ -121,7 +121,7 @@ function verify_config_connector_operator_installed { CONFIG CONNECTOR OPERATOR NOT FOUND As of 1.33, the operator (or the GKE add-on) is the only supported -method to install Config Conector. +method to install Config Connector. remediation: diff --git a/scripts/dclsampleconverter/strings.py b/scripts/dclsampleconverter/strings.py index 35e2c57b19..058281c932 100644 --- a/scripts/dclsampleconverter/strings.py +++ b/scripts/dclsampleconverter/strings.py @@ -43,7 +43,7 @@ 'url': 'URL', 'vpcaccess': 'VPCAccess', 'vpn': 'VPN', -} # Replacement map for KCC Kinds. Keys are case insensitive. +} # Replacement map for KCC Kinds. Keys are case-insensitive. class colors: diff --git a/scripts/generate-google3-docs/resource-reference/generated/resource-docs/bigquery/bigquerydataset.md b/scripts/generate-google3-docs/resource-reference/generated/resource-docs/bigquery/bigquerydataset.md index f82bcfceb6..678fc72837 100644 --- a/scripts/generate-google3-docs/resource-reference/generated/resource-docs/bigquery/bigquerydataset.md +++ b/scripts/generate-google3-docs/resource-reference/generated/resource-docs/bigquery/bigquerydataset.md @@ -394,7 +394,7 @@ storageBillingModel: string afterwards, and does not alter the existing tables. The following values are supported: - * 'und:ci': undetermined locale, case insensitive. + * 'und:ci': undetermined locale, case-insensitive. * '': empty string. Default to case-sensitive behavior.{% endverbatim %}
diff --git a/scripts/generate-google3-docs/resource-reference/generated/resource-docs/compute/computetargethttpsproxy.md b/scripts/generate-google3-docs/resource-reference/generated/resource-docs/compute/computetargethttpsproxy.md index 4beeff428b..6b7797bf48 100644 --- a/scripts/generate-google3-docs/resource-reference/generated/resource-docs/compute/computetargethttpsproxy.md +++ b/scripts/generate-google3-docs/resource-reference/generated/resource-docs/compute/computetargethttpsproxy.md @@ -135,7 +135,7 @@ urlMapRef:object
{% verbatim %}URLs to certificate manager certificate resources that are used to authenticate connections between users and the load balancer. Currently, you may specify up to 15 certificates. Certificate manager certificates do not apply when the load balancing scheme is set to INTERNAL_SELF_MANAGED. -sslCertificates and certificateManagerCertificates fields can not be defined together.{% endverbatim %}
+sslCertificates and certificateManagerCertificates fields cannot be defined together.{% endverbatim %}string
{% verbatim %}Immutable. Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfg' are exempted.{% endverbatim %}
+{% verbatim %}Immutable. Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfig' are exempted.{% endverbatim %}
string
{% verbatim %}Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfg' are exempted.{% endverbatim %}
+{% verbatim %}Required. The service for which to enable Data Access audit logs. The special value 'allServices' covers all services. Note that if there are audit configs covering both 'allServices' and a specific service, then the union of the two audit configs is used for that service: the 'logTypes' specified in each 'auditLogConfig' are enabled, and the 'exemptedMembers' in each 'auditLogConfig' are exempted.{% endverbatim %}